nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
977 stars 240 forks source link

Email notification option disappeared in 3.2.0 #4032

Closed dinosmm closed 2 years ago

dinosmm commented 2 years ago

Steps to reproduce

  1. Either create a new event or edit an existing one
  2. Set a notification
  3. Click on three dots, there is no longer an option to set an email notification

Expected behavior

Ability to set a notification as 'email'

Actual behaviour

Email notification option does not exist

Calendar app version

3.2.0

CalDAV-clients used

No response

Browser

Firefox 97.0.2

Client operating system

Ubuntu 20.04

Server operating system

Ubuntu 20.04

Web server

Nginx

Database engine version

MariaDB

PHP engine version

PHP 7.4

Nextcloud version

22.2.3

Updated from an older installed version or fresh install

Fresh install

List of activated apps

nabled:
  - accessibility: 1.8.0
  - activity: 2.15.0
  - apporder: 0.14.0
  - bruteforcesettings: 2.3.0
  - calendar: 3.2.0
  - circles: 22.1.1
  - cloud_federation_api: 1.5.0
  - comments: 1.12.0
  - contacts: 4.0.8
  - dashboard: 7.2.0
  - dav: 1.19.0
  - event_update_notification: 1.4.0
  - extract: 1.3.3
  - federatedfilesharing: 1.12.0
  - federation: 1.12.0
  - files: 1.17.0
  - files_accesscontrol: 1.12.1
  - files_downloadactivity: 1.12.0
  - files_downloadlimit: 0.1.3
  - files_external: 1.13.0
  - files_pdfviewer: 2.3.1
  - files_rightclick: 1.1.0
  - files_sharing: 1.14.0
  - files_trackdownloads: 1.11.0
  - files_trashbin: 1.12.0
  - files_versions: 1.15.0
  - files_videoplayer: 1.11.0
  - firstrunwizard: 2.11.0
  - groupfolders: 10.0.2
  - guests: 2.1.0
  - logreader: 2.7.0
  - lookup_server_connector: 1.10.0
  - maps: 0.1.10
  - news: 18.0.0
  - nextcloud_announcements: 1.11.0
  - notes: 4.3.1
  - notifications: 2.10.1
  - oauth2: 1.10.0
  - password_policy: 1.12.0
  - phonetrack: 0.7.0
  - photos: 1.4.0
  - privacy: 1.6.0
  - provisioning_api: 1.12.0
  - radio: 1.0.3
  - recommendations: 1.1.0
  - richdocuments: 4.2.5
  - riotchat: 0.11.2
  - serverinfo: 1.12.0
  - settings: 1.4.0
  - sharebymail: 1.12.0
  - spreed: 12.2.3
  - support: 1.5.0
  - survey_client: 1.10.0
  - suspicious_login: 4.1.0
  - systemtags: 1.12.0
  - text: 3.3.0
  - theming: 1.13.0
  - theming_customcss: 1.10.0
  - twofactor_admin: 3.2.0
  - twofactor_backupcodes: 1.11.0
  - twofactor_gateway: 0.19.0
  - twofactor_nextcloud_notification: 3.3.1
  - twofactor_totp: 6.2.0
  - twofactor_u2f: 6.3.0
  - twofactor_webauthn: 0.3.1
  - unsplash: 1.2.4
  - updatenotification: 1.12.0
  - user_status: 1.2.0
  - viewer: 1.6.0
  - weather_status: 1.2.0
  - welcome: 1.0.1
  - workflowengine: 2.4.0
Disabled:
  - admin_audit
  - contactsinteraction
  - encryption
  - files_fulltextsearch
  - fulltextsearch
  - user_ldap

Nextcloud configuration

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "cloud.domain.com"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "22.2.3.0",
        "overwrite.cli.url": "https:\/\/cloud.domain.com",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "filelocking.enabled": true,
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "memcache.local": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 6379,
            "timeout": 0,
            "password": "***REMOVED SENSITIVE VALUE***"
        },
        "default_phone_region": "GB",
        "twofactor_enforced": "true",
        "twofactor_enforced_groups": [],
        "twofactor_enforced_excluded_groups": [],
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "mail_smtptimeout": 30,
        "log_type": "file",
        "logfile": "\/home\/username\/log\/nextcloud.log",
        "loglevel": 1,
        "logdateformat": "F d, Y H:i:s",
        "maintenance": false,
        "app_install_overwrite": [
            "radio"
        ],
        "has_rebuilt_cache": true
    }
}

Web server error log

No response

Log file

No response

Browser log

No response

Additional info

No response

WladyX commented 2 years ago

I have this also, wondering if we can downgrade the app now. Thanks

dinosmm commented 2 years ago

I have this also, wondering if we can downgrade the app now. Thanks

Yes I downgraded to 3.1.0 and the notification and email radio buttons now appear again. This is definitely a UI bug with 3.2.0.

m-a-v commented 2 years ago

I can also confirm this bug with 3.2.0 and Nextcloud Hub II (23.0.2). I am not able to downgrade the app. When doing it manually Nextcloud requires to upgrade the app so I am again on calendar 3.2.0. It would be nice to have soon a fix for this (or a hint how I can downgrade to 3.1.0). Thanks.

dinosmm commented 2 years ago

I disabled the Calendar app, downloaded 3.1.0 from the official page, deleted the calendar directory from /var/www/nextcloud/apps/, untarred the 3.1.0 calendar in there, and re-enabled the app from NC settings. It did take me a couple of times doing that (the first time it did keep insisting on upgrading calendar again), but eventually it accepted it.

m-a-v commented 2 years ago

@ChristophWurst Could this be related to changes you've done?

m-a-v commented 2 years ago

I think this could be this PR. But it seems that this is not optionally enforced, but enforced by default now :-(.

https://github.com/nextcloud/calendar/pull/3997

m-a-v commented 2 years ago

I often use mixed alarms (MAIL and DISPLAY) and now I can't see it anymore.

If a reminder matches the enforced type, we hide the radio group all together (there would only be one option after all)

I think a better solution would be to have a greyed out element, such that you still can see how you are informed.

dinosmm commented 2 years ago

Oh dear... was this on purpose? This seems to be documented in the changelog as 'allow admins to force an event type', which does not tell much (we are talking about notification types here, surely, not event types). How do you un-force it so we get the option back?

I personally think removing those options is a bad idea - I dare say I am not the only one who sets different reminders to different events based on many criteria; for some I want an email, for others I want a reminder (which my caldav-linked phone calendar handles very well). Never a good idea to remove options that have been around for a long time and people have got used to. Most, if not all, other calendars allow per-event notification/email setting, for a good reason.

m-a-v commented 2 years ago

It seems that null is not a valid option. So I think this feature was intended to be off by default ... but it doesn't work.

see here: https://github.com/nextcloud/calendar/pull/3997#discussion_r825412876

dinosmm commented 2 years ago

Oh so it is meant to be optional whether to hide the selections or not? That's good to know!

m-a-v commented 2 years ago

Oh so it is meant to be optional whether to hide the selections or not? That's good to know!

Yes. But it's just my assumption when reading the code and the comments ...

dinosmm commented 2 years ago

The earliest this fix will be released is 3.2.2 right? I'm no github expert but from what I can see this is not in 3.2.1, just checking I am correct.

aledef commented 2 years ago

The earliest this fix will be released is 3.2.2 right? I'm no github expert but from what I can see this is not in 3.2.1, just checking I am correct.

I confirm is not on 3.2.1 I have just upgraded and the bug is still there

dinosmm commented 2 years ago

I can see (if I understand it correctly) this has been set on the 3.3.0 milestone. Can anyone confirm if it's still not fixed on 3.2.2?

m-a-v commented 2 years ago

It was fixed with 3.2.2.