nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
984 stars 241 forks source link

Rework reflow on the mobile devices #4283

Open JuliaKirschenheuter opened 2 years ago

JuliaKirschenheuter commented 2 years ago

Steps to reproduce

This is an accessibility issue.

When using the app on a smaller, vertical screen and activating “New event” a fly-out menu opens from the right. This should open on top of interface, but it opens under the menu field, and the user won’t be able to reach it.

This does not technically fail this WCAG-criterion, though it would be a serious issue for someone trying to use the app on a mobile phone.

Expected behavior

Popover comes in front (on the top) of the view.

Actual behaviour

At the moment it looks like this

image

Calendar app version

3.3.2

CalDAV-clients used

No response

Browser

No response

Client operating system

No response

Server operating system

No response

Web server

No response

Database engine version

No response

PHP engine version

No response

Nextcloud version

No response

Updated from an older installed version or fresh install

No response

List of activated apps

No response

Nextcloud configuration

No response

Web server error log

No response

Log file

No response

Browser log

No response

Additional info

No response

szaimen commented 2 years ago

Does https://github.com/nextcloud/nextcloud-vue/pull/2747 address this?

JuliaKirschenheuter commented 2 years ago

Does nextcloud/nextcloud-vue#2747 address this?

This ticket fixes a problem with a sidebar.

I've tested it with modal + (not completely) hidden sidebar - and this doesn't work

szaimen commented 2 years ago

I've tested it with modal + (not completely) hidden sidebar - and this doesn't work

Can you post a screenshot of this?

JuliaKirschenheuter commented 2 years ago

I've tested it with modal + (not completely) hidden sidebar - and this doesn't work

Can you post a screenshot of this?

This one https://github.com/nextcloud/calendar/issues/4283#issue-1269669611

szaimen commented 2 years ago

This one #4283 (comment)

Okay but this should be fixed with https://github.com/nextcloud/nextcloud-vue/pull/2747 due to the z-index change...

JuliaKirschenheuter commented 2 years ago

Okay but this should be fixed with nextcloud/nextcloud-vue#2747 due to the z-index change...

Hm, i've tested it, but haven't seen a difference. Could you test it too?

szaimen commented 2 years ago

If you have tested it I guess it does not work as expected... Can you show a screenshot of your test? Does it still look the same like your initial report here?

JuliaKirschenheuter commented 2 years ago

Does it still look the same like your initial report here?

yes =(

szaimen commented 2 years ago

yes =(

Then your test does not seem to work... Did you clear all caches and linked the vue repo correctly?

szaimen commented 2 years ago

yes =(

Then your test does not seem to work... Did you clear all caches and linked the vue repo correctly?

I am asking because at least the right sidebar should then span the whole width on mobile (below 512px)

szaimen commented 2 years ago

This can now be tested again with https://github.com/nextcloud/nextcloud-vue/releases/tag/v6.0.0-alpha.0

szaimen commented 2 years ago

Also the new calendar beta release contains this fix now.