nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
981 stars 241 forks source link

Replace "Week ... of ..." with new native date picker #4522

Open st3iny opened 2 years ago

st3iny commented 2 years ago

Is your feature request related to a problem? Please describe.

Clicking on the week select in the top left corner still opens the old date picker.

image

Describe the solution you'd like

It should use the new native date picker with improved a11y.

Describe alternatives you've considered

No response

Additional context

This requires some research if this is actually doable since it's a button. The native date picker usually requires an input.

ChristophWurst commented 2 years ago

AppNavigationHeaderDatePicker uses Calendar's wrapper of the @nextcloud/vue datepicker. This makes it less trivial to switch to a native datepicker here.

I am assuming that we need a new prop on the native datepicker to make it visually hidden. But then I am not sure if triggering a click or focus on the native picker results in an accessible solution. E.g. keyboard input will no longer work because we don't show the input field.

I will drop the ticket off the priority changes for v4/Nextcloud 25.

RokeJulianLockhart commented 1 year ago

What does the new native picker look like?

ChristophWurst commented 1 year ago

https://nextcloud-vue-components.netlify.app/#/Components/NcPickers?id=ncdatetimepickernative