nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
986 stars 239 forks source link

Modify events are sent as new events and not updates (via email) #5046

Open maximelehericy opened 1 year ago

maximelehericy commented 1 year ago

Steps to reproduce

Two users: Bob is internal user, Alice is external user.

  1. Bob creates an event in his Nextcloud calendar, for tomorrow from 2PM to 3PM

  2. He adds Alice to the ilst of participants

  3. He finalize the event creation, clicking on "Save"

  4. Alice receives the invitation email, and import the ics event in her calendar (btw, Nextcloud mail feature is broken https://github.com/nextcloud/mail/issues/7444, so to reproduce, either use a third-party calendar app, or download locally the event and import it from the calendar settings)

  5. Alice now has Bob's event in her calendar.

  6. Now, Bob edit the meeting time, from 4PM to 5PM.

  7. Bob clicks update, to update the event.

  8. Alice will receive the notification that she is invited to a new event.

  9. Alice tries to import the event (repeat step 4)

Expected behavior

Event should get updated in Alice's calendar (Thunderbird or Nextcloud)

Actual behaviour

In Nextcloud calendar, a failed message appears. In Thunderbird nothing happens.

My guess is that the invitation is sent as if it were a new event, instead of being sent as an event update. Therefore there is a conflict, because you try to create an event that already exists.

Calendar app version

4.2.4

CalDAV-clients used

Thunderbird, Nextcloud calendar

Browser

Firefox 110.0.1 (64-bit)

Client operating system

Windows 11

Server operating system

c.nc.c and try.nc.c/ltd

Web server

None

Database engine version

None

PHP engine version

None

Nextcloud version

No response

Updated from an older installed version or fresh install

None

List of activated apps

No response

Nextcloud configuration

No response

Web server error log

No response

Log file

No response

Browser log

No response

Additional info

No response

ChristophWurst commented 1 year ago

https://github.com/nextcloud/server/pull/35743#issuecomment-1408912400 @miaulalala @onny is there an existing ticket for new vs updated event emails?

miaulalala commented 1 year ago

There is a ticket in sabre/io: https://github.com/sabre-io/dav/pull/1443/files whichis related.

The import assumes a new event and throws because of the UID conflic methinks, to be confirmed. We don't have any influence on Thunderbird, but since both calendar systems throw it looks indeed to be an issue with the .ics.

Der-K-2000 commented 1 year ago

Is this related to an issue, I had today?

  1. I created an event.
  2. I invited an external collegue to this event, who's not registered.
  3. The person clicked the link in the mail to accept.
  4. On my server this error appears:

There was an error updating your attendance status. Please contact the organizer directly. my m@il-address

  1. The collegue didn't change anything and only clicked the accept-link.

Versions: NextCloud 26.0.0 RC2 Calendar 4.3.0-rc.2

onny commented 1 year ago

@SebastianBerlin Since your issue is not about updating an existing event, it is not related. Please have a look if there's a similar issue or open a new one.

Der-K-2000 commented 1 year ago

@SebastianBerlin Since your issue is not about updating an existing event, it is not related. Please have a look if there's a similar issue or open a new one.

Indeed → https://github.com/nextcloud/mail/issues/10331 Thanks!

maximelehericy commented 1 year ago

@miaulalala by chance, did you have a look to the ics I sent you ? :)

eleith commented 1 year ago

@maximelehericy, the mail app importing is working now (the bug you linked to in the description has now been closed).

i can reproduce the error you are describing when importing using the mail app calendar import function. (ex: the first import works, the second import results in an error)

maximelehericy commented 1 year ago

will try again when I have a bit of time ;)