X-WR-CALNAME of shared calendar shows the username in addition to the calendar name

KiaraGrouwstra commented 1 year ago

Steps to reproduce

go to Nextcloud Calendar app
copy a shared calendar's subscription link
access the link using e.g. curl
find X-WR-CALNAME contains the user name in addition to the calendar name

Expected behavior

calendar name contains just the calendar name

Actual behaviour

calendar name follows the pattern <calendar_name> (<user_name>)

Calendar app version

3.5.5

CalDAV-clients used

No response

Browser

No response

Client operating system

No response

Server operating system

Debian

Web server

None

Database engine version

None

PHP engine version

PHP 8.0

Nextcloud version

24.0.5

Updated from an older installed version or fresh install

None

List of activated apps

Enabled:
  - accessibility: 1.10.0
  - activity: 2.16.0
  - announcementcenter: 6.3.1
  - appointments: 1.14.11
  - bbb: 2.4.0
  - bruteforcesettings: 2.4.0
  - calendar: 3.5.5
  - circles: 24.0.1
  - cloud_federation_api: 1.7.0
  - collectives: 1.6.3
  - comments: 1.14.0
  - contacts: 4.2.5
  - contactsinteraction: 1.5.0
  - dashboard: 7.4.0
  - dav: 1.22.0
  - deck: 1.7.3
  - encryption: 2.12.0
  - external: 4.0.1
  - federatedfilesharing: 1.14.0
  - federation: 1.14.0
  - files: 1.19.0
  - files_accesscontrol: 1.14.1
  - files_antivirus: 4.0.2
  - files_external: 1.16.1
  - files_markdown: 2.3.6
  - files_pdfviewer: 2.5.0
  - files_rightclick: 1.3.0
  - files_sharing: 1.16.2
  - files_texteditor: 2.15.0
  - files_trashbin: 1.14.0
  - files_versions: 1.17.0
  - files_videoplayer: 1.13.0
  - firstrunwizard: 2.13.0
  - forms: 2.5.2
  - groupfolders: 12.0.3
  - jitsi: 0.15.0
  - logreader: 2.9.0
  - lookup_server_connector: 1.12.0
  - mail: 1.15.2
  - nextcloud_announcements: 1.13.0
  - notes: 4.5.1
  - notifications: 2.12.0
  - oauth2: 1.12.0
  - password_policy: 1.14.0
  - photos: 1.6.0
  - polls: 3.8.4
  - privacy: 1.8.0
  - provisioning_api: 1.14.0
  - ransomware_protection: 1.14.0
  - richdocuments: 6.3.4
  - richdocumentscode: 22.5.802
  - serverinfo: 1.14.0
  - settings: 1.6.0
  - sharebymail: 1.14.0
  - spreed: 14.0.9
  - systemtags: 1.14.0
  - talk_matterbridge: 1.25.2
  - tasks: 0.14.5
  - text: 3.5.1
  - theming: 1.15.0
  - theming_customcss: 1.12.0
  - twofactor_backupcodes: 1.13.0
  - twofactor_gateway: 0.20.0
  - twofactor_totp: 6.4.1
  - twofactor_webauthn: 0.3.3
  - updatenotification: 1.14.0
  - user_ldap: 1.14.1
  - user_oidc: 1.3.1
  - user_status: 1.4.0
  - viewer: 1.8.0
  - weather_status: 1.4.0
  - workflowengine: 2.6.0
Disabled:
  - admin_audit
  - recommendations: 1.2.0
  - registration: 1.5.0
  - support: 1.6.0
  - survey_client: 1.11.0

Nextcloud configuration

{
    "system": {
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "localhost",
            "cloud.bij1.org"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "pgsql",
        "version": "24.0.4.1",
        "overwrite.cli.url": "https:\/\/cloud.bij1.org",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "default_language": "nl",
        "default_locale": "nl_NL",
        "overwriteprotocol": "https",
        "debug": "true",
        "default_phone_region": "NL",
        "memcache.local": "\\OC\\Memcache\\Redis",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": "6379"
        },
        "mail_smtpmode": "smtp",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "587",
        "mail_smtpsecure": "tls",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_user": "nextcloud",
        "mail_from": "nextcloud",
        "mail_sendmailmode": "smtp",
        "mail_smtpauth": 1,
        "mail_smtpauthtype": "PLAIN",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "maintenance": false,
        "theme": "",
        "loglevel": 2,
        "ldapProviderFactory": "OCA\\User_LDAP\\LDAPProviderFactory",
        "app_install_overwrite": [
            "files_texteditor"
        ],
        "twofactor_enforced": "false",
        "twofactor_enforced_groups": [],
        "twofactor_enforced_excluded_groups": []
    }
}

Web server error log

No response

Log file

No response

Browser log

No response

Additional info

my use-case here is publishing a nextcloud calendar on our wordpress website. to this end we use a wordpress plugin that displays ICS calendars from ICS feed (link), not built specifically for ICS feeds generated from nextcloud. displaying such calendars that way ends up displaying the name of the user in the calendar names as well. this information seems not particularly relevant to users browsing the calendar.

ChristophWurst commented 1 year ago

calendar name follows the pattern <calendar_name> (<user_name>)

That is the naming pattern for shared calendars inside your calendar home

Not sure if that should be stripped if you republish someone's calendar

tcitworld commented 1 year ago

It would be hard in any case to do that, a better way would to be completely stop rewriting the calendar's display name and use share information to show who shared the calendar with you (which is what https://github.com/nextcloud/calendar/issues/5083 suggests), pretty much like how file sharing works. A drawback is that we won't have the sharee name anymore on 3rd-party CalDAV clients.

nextcloud / calendar