nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
985 stars 241 forks source link

localization of booking-confirmation #5527

Open asaage opened 1 year ago

asaage commented 1 year ago

Steps to reproduce

booking appointments

Expected behavior

The confirmation-page should respect the correct locale.

Actual behaviour

There is a bug in the localized confirmation of booked appointments. The {startDate} - {endDate} should consider the appropiate locale (in my case de_DE) The current output is Danke schön. Ihre Buchung vom October 16, 2023 2:00 PM bis October 16, 2023 2:20 PM wurde bestätigt. Which ist not english and not german but a mix. It should be something like Oktober and 14:00

https://github.com/nextcloud/calendar/blob/main/l10n/de_DE.json#L395 https://github.com/nextcloud/calendar/blob/main/l10n/de_DE.js#L397

Calendar app version

4.5.2

CalDAV-clients used

No response

Browser

No response

Client operating system

No response

Server operating system

No response

Web server

None

Database engine version

None

PHP engine version

None

Nextcloud version

27.1.2

Updated from an older installed version or fresh install

None

List of activated apps

No response

Nextcloud configuration

No response

Web server error log

No response

Log file

No response

Browser log

No response

Additional info

No response

miaulalala commented 1 year ago

Localisation is done here:

https://github.com/nextcloud/calendar/blob/d8a26ce41bafeae18302df8b39b222165149697b/src/views/Appointments/Conflict.vue#L48-L54

cc @st3iny