nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
968 stars 236 forks source link

Calendar Embed Reveals Username #5721

Open thw26 opened 7 months ago

thw26 commented 7 months ago

Steps to reproduce

  1. Embed a calendar
  2. Hover mouse of the export buttons in the top right
  3. View the toast

Expected behavior

When hovering over the toast, only the calendar name should be revealed, not the username. If a username must be revealed, then it should be the display name.

Actual behaviour

When hovering over the export buttons, you see the username.

Calendar app version

4.6.4

CalDAV-clients used

No response

Browser

Firefox 121

Client operating system

Manjaro Linux

Server operating system

Ubuntu

Web server

Nginx

Database engine version

MariaDB

PHP engine version

PHP 8.2

Nextcloud version

28.0.1

Updated from an older installed version or fresh install

Fresh install

List of activated apps

Default plus custom CSS

Nextcloud configuration

Nothing here that is not already shared.

Web server error log

No response

Log file

No response

Browser log

No response

Additional info

No response

Steinbam commented 6 months ago

I would also appreciate if we could hide the user completely (could also be a config option when creating the sharing link?). We are sharing several calendars of our organization to the public and it is definitively undesirable to reveal the owner of the calendars (which is irrelevant anyhow), no matter if it is the username or the display name.

miaulalala commented 6 months ago

If we do need the username but we could hash it or take a token based approach on sharing calendars. Haven't looked into it too deeply yet.