nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
975 stars 240 forks source link

fix(editor): add indicator to calendar picker #5984

Closed st3iny closed 5 months ago

st3iny commented 5 months ago

Fix https://github.com/nextcloud/calendar/issues/5855

This is dirty but the NcActionButton does not allow custom components inside its default template slot. Only text can be used.

Light Dark
picker-light Screenshot_20240503_171632
codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 29.16%. Comparing base (ccf5f95) to head (0dfb690). Report is 5 commits behind head on main.

Files Patch % Lines
src/components/Editor/CalendarPickerHeader.vue 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5984 +/- ## ============================================ + Coverage 23.51% 29.16% +5.64% - Complexity 455 910 +455 ============================================ Files 246 287 +41 Lines 11718 13983 +2265 Branches 2155 2157 +2 ============================================ + Hits 2756 4078 +1322 - Misses 8647 9589 +942 - Partials 315 316 +1 ``` | [Flag](https://app.codecov.io/gh/nextcloud/calendar/pull/5984/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/nextcloud/calendar/pull/5984/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `15.15% <0.00%> (-0.01%)` | :arrow_down: | | [php](https://app.codecov.io/gh/nextcloud/calendar/pull/5984/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `58.46% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.