search

nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
975 stars 240 forks source link

fix(editor): don't respect default calendar in the calendar picker #5996

Closed st3iny closed 4 months ago

st3iny commented 4 months ago

Ref https://github.com/nextcloud/calendar/issues/5942 Partially reverts https://github.com/nextcloud/calendar/pull/5790

The default calendar URL from the backend is more restrictive as it is primarily meant for incoming invitations. This commit effectively reverts the editor's calendar picker default choice to how it behaved before v4.7.0.

As discussed in a meeting with Christoph.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 23.51%. Comparing base (397c78e) to head (4f2caf6). Report is 2 commits behind head on main.

Files Patch % Lines
src/components/AppNavigation/Settings.vue 0.00% 2 Missing :warning:
src/store/calendarObjects.js 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5996 +/- ## ========================================= Coverage 23.51% 23.51% Complexity 455 455 ========================================= Files 246 246 Lines 11722 11718 -4 Branches 2156 2154 -2 ========================================= Hits 2756 2756 + Misses 8650 8647 -3 + Partials 316 315 -1 ``` | [Flag](https://app.codecov.io/gh/nextcloud/calendar/pull/5996/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/nextcloud/calendar/pull/5996/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `15.16% <0.00%> (+<0.01%)` | :arrow_up: | | [php](https://app.codecov.io/gh/nextcloud/calendar/pull/5996/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `58.46% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

st3iny commented 4 months ago

Backport is tricky due to translation changes.