nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
975 stars 240 forks source link

fix(alarms): also update DISPLAY alarms #6008

Closed miaulalala closed 4 months ago

miaulalala commented 4 months ago

Fixes https://github.com/nextcloud/calendar/issues/3040

miaulalala commented 4 months ago

/backport to stabe4.7

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 23.54%. Comparing base (397c78e) to head (b66f96a). Report is 16 commits behind head on main.

Files Patch % Lines
src/utils/alarms.js 0.00% 1 Missing and 1 partial :warning:
src/store/calendarObjectInstance.js 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6008 +/- ## ============================================ + Coverage 23.51% 23.54% +0.03% Complexity 455 455 ============================================ Files 246 246 Lines 11722 11707 -15 Branches 2156 2142 -14 ============================================ Hits 2756 2756 + Misses 8650 8637 -13 + Partials 316 314 -2 ``` | [Flag](https://app.codecov.io/gh/nextcloud/calendar/pull/6008/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/nextcloud/calendar/pull/6008/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `15.18% <0.00%> (+0.02%)` | :arrow_up: | | [php](https://app.codecov.io/gh/nextcloud/calendar/pull/6008/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `58.46% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

backportbot[bot] commented 4 months ago

The backport to stabe4.7 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stabe4.7
git pull origin stabe4.7

# Create the new backport branch
git checkout -b backport/6008/stabe4.7

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b66f96ab

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6008/stabe4.7

Error: Failed to clone repository: Failed to checkout branches: error: pathspec 'stabe4.7' did not match any file(s) known to git


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.