nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
989 stars 240 forks source link

Add all holiday calendars from Thunderbird? #6011

Open nclm opened 6 months ago

nclm commented 6 months ago

Is your feature request related to a problem? Please describe.

I like the fact that we can add holiday calendars straight from Nextcloud, provided by Thunderbird.

Those are the choices in Nextcloud right now (about 56): https://github.com/nextcloud/server/assets/923008/2a6713da-1ac4-40f5-8054-d1808fcbeecd

However Thunderbird.net offers more calendars that that (about 86): https://github.com/nextcloud/server/assets/923008/64d172ec-228c-457e-ba67-9bd93e16a28d as can been seen on https://www.thunderbird.net/en-US/calendar/holidays/

Describe the solution you'd like Include all calendars offered by Thunderbird in Nextcloud. Additionally, if there could be a way to automatically update the list in Nextcloud if Thunderbird adds or change their calendar, that would be useful to avoid differences like that in the future.

joshtrichards commented 6 months ago

The list is currently manually maintained. It's located here:

https://github.com/nextcloud/calendar/blob/b2d23f855269ab34494701a9df1bcdbd9792a904/src/resources/holiday_calendars.json

It was just updated a few months ago. I'm not sure if some were left out at the time or if new ones have since been added @ Thunderbird.

Feel free to make some additions to it and submit them via a PR. :-)

nclm commented 6 months ago

Alright, it seems that https://github.com/nextcloud/calendar/blob/main/src/resources/holiday_calendars.json is simply a copy of https://github.com/thunderbird/thunderbird-website/blob/master/media/caldata/calendars.json, which makes sense.

But Thunderbird is now using https://github.com/thunderbird/thunderbird-website/blob/master/media/caldata/autogen/calendars.json since last year, with (more) calendars auto-updated every quarter from a “calendar provider”. If you are up for using these, replacing holiday_calendars.json with the contents of autogen/calendars.json could do the job (as long as Nextcloud can handle the extra fields (locale, language, updated).

miaulalala commented 6 months ago

Alright, it seems that main/src/resources/holiday_calendars.json is simply a copy of thunderbird/thunderbird-website@master/media/caldata/calendars.json, which makes sense.

But Thunderbird is now using thunderbird/thunderbird-website@master/media/caldata/autogen/calendars.json since last year, with (more) calendars auto-updated every quarter from a “calendar provider”. If you are up for using these, replacing holiday_calendars.json with the contents of autogen/calendars.json could do the job (as long as Nextcloud can handle the extra fields (locale, language, updated).

Feel free to edit the file and push a PR :smile: you can even do it from github by going to https://github.com/nextcloud/calendar/blob/main/src/resources/holiday_calendars.json and clicking "Edit File" in the top right.

nclm commented 6 months ago

Great, I made the edit here: #6014