nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
953 stars 235 forks source link

Make certain wordings translatable #6021

Closed Jerome-Herbinet closed 1 month ago

Jerome-Herbinet commented 2 months ago

Just check commit.

Test from reviewers is need.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 23.59%. Comparing base (f874071) to head (3c97791). Report is 114 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6021 +/- ## ========================================= Coverage 23.59% 23.59% Complexity 457 457 ========================================= Files 246 246 Lines 11715 11715 Branches 2140 2140 ========================================= Hits 2764 2764 Misses 8637 8637 Partials 314 314 ``` | [Flag](https://app.codecov.io/gh/nextcloud/calendar/pull/6021/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/nextcloud/calendar/pull/6021/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `15.18% <ø> (ø)` | | | [php](https://app.codecov.io/gh/nextcloud/calendar/pull/6021/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `58.61% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

miaulalala commented 1 month ago

Tests fail bc the new calls to l10n need to be added. I'll check in a minute and let you know where and how to add these :)

github-actions[bot] commented 1 month ago

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)