nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
949 stars 232 forks source link

changed events should send email #6024

Open Zweihorn opened 1 month ago

Zweihorn commented 1 month ago

Is your feature request related to a problem? Please describe.

Apparently, changing an event does not send emails to participants about the change and this becomes lost to external clients which accepted the event after the first invitation (e.g., Thunderbird).

Describe the solution you'd like

Changing the date and/or time of an event shall send emails to participants about the change as applicable.

Describe alternatives you've considered

none

Additional context

May be a duplicate but this plethora of issues found with searching "change" made it difficult to find one in due time if this would exist already. 😇

However, keep on the good work and prosper.

🌻

SebastianKrupinski commented 1 month ago

@Zweihorn This is a know bug, we are already working on fixing this.

Zweihorn commented 1 month ago

This is a know bug, we are already working on fixing this.

👍

Just curios which one and which issue number, if I may?

🤔

SebastianKrupinski commented 1 month ago

Confirmed.

Cause

This is being caused by the significant changes test.

https://github.com/nextcloud/server/blob/48e62405021627914c7fc6dd58168e011cb0f574/apps/dav/lib/CalDAV/Schedule/IMipPlugin.php#L109-L114

The sabre/vobject/lib/ITip/Broker class considers only changes to 'DTSTART', 'DTEND', 'DURATION', 'DUE', 'RRULE', 'RDATE', 'EXDATE', 'STATUS' as significant.

Solution

Zweihorn commented 1 month ago

Confirmed.

Cause

This is being caused by the significant changes test.

@SebastianKrupinski - THX alot.

Keep on the good work and prosper.

🌻