nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
949 stars 232 forks source link

fix(editor): calendar picker width #6040

Closed st3iny closed 1 month ago

st3iny commented 1 month ago

Follow-up to https://github.com/nextcloud/calendar/pull/6032

Before: grafik

Simple Editor

Edit View

Multiple calendar options

Short name Long name
grafik grafik

Single calendar option

Short name Long name
grafik grafik

Read-only View (shared calendar)

Short name Long name
grafik grafik

Sidebar Editor

Multiple calendar options

Short name Long name
grafik grafik

Single calendar option

Short name Long name
grafik grafik

Read-only view (shared calendar)

Short name Long name
grafik grafik

This also fixes the popover position which would sometimes be anchored in the middle of the editor instead of the picker action button itself.

grafik

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 23.59%. Comparing base (ae4a149) to head (e35da5f). Report is 12 commits behind head on main.

Files Patch % Lines
src/components/Editor/CalendarPickerHeader.vue 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6040 +/- ## ========================================= Coverage 23.59% 23.59% Complexity 457 457 ========================================= Files 246 246 Lines 11715 11714 -1 Branches 2140 2150 +10 ========================================= Hits 2764 2764 + Misses 8637 8635 -2 - Partials 314 315 +1 ``` | [Flag](https://app.codecov.io/gh/nextcloud/calendar/pull/6040/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/nextcloud/calendar/pull/6040/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `15.18% <0.00%> (+<0.01%)` | :arrow_up: | | [php](https://app.codecov.io/gh/nextcloud/calendar/pull/6040/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `58.61% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

st3iny commented 1 month ago

/backport to stable4.7