nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
947 stars 231 forks source link

fix: attachment folder picker #6082

Closed st3iny closed 4 days ago

st3iny commented 1 week ago

There were some breaking changes in the dialogs library we missed.

Before: Default attachment folder picker doesn't open. After: It opens as usual.

Does not need to be backported as the dependency bump was not backported.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 24.02%. Comparing base (9cb56bd) to head (93374fa). Report is 5 commits behind head on main.

Files Patch % Lines
...pNavigation/Settings/SettingsAttachmentsFolder.vue 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6082 +/- ## ============================================ - Coverage 29.71% 24.02% -5.69% + Complexity 914 457 -457 ============================================ Files 287 246 -41 Lines 13835 11565 -2270 Branches 2163 2153 -10 ============================================ - Hits 4111 2779 -1332 + Misses 9409 8472 -937 + Partials 315 314 -1 ``` | [Flag](https://app.codecov.io/gh/nextcloud/calendar/pull/6082/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/nextcloud/calendar/pull/6082/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `15.56% <0.00%> (-0.01%)` | :arrow_down: | | [php](https://app.codecov.io/gh/nextcloud/calendar/pull/6082/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `58.65% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ChristophWurst commented 1 week ago

conflicts again