nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
947 stars 231 forks source link

chore: revert moment plugin factory pattern #6089

Open st3iny opened 1 week ago

st3iny commented 1 week ago

We use Pinia now and we don't have to pass a store to the moment plugin anymore. The factory pattern is thus not required anymore.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 29.71%. Comparing base (9cb56bd) to head (bfc8dfd). Report is 2 commits behind head on main.

Files Patch % Lines
src/components/CalendarGrid.vue 0.00% 1 Missing :warning:
src/components/Editor/FreeBusy/FreeBusy.vue 0.00% 1 Missing :warning:
src/fullcalendar/localization/momentPlugin.js 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6089 +/- ## ========================================= Coverage 29.71% 29.71% Complexity 914 914 ========================================= Files 287 287 Lines 13835 13833 -2 Branches 2163 2152 -11 ========================================= Hits 4111 4111 + Misses 9409 9408 -1 + Partials 315 314 -1 ``` | [Flag](https://app.codecov.io/gh/nextcloud/calendar/pull/6089/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/nextcloud/calendar/pull/6089/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `15.57% <0.00%> (+<0.01%)` | :arrow_up: | | [php](https://app.codecov.io/gh/nextcloud/calendar/pull/6089/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `58.65% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.