nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
947 stars 231 forks source link

Revert "fix: scope global sidebar styles to the app" #6091

Closed miaulalala closed 1 week ago

miaulalala commented 1 week ago

This reverts commit 2460c539e8b7fdd0b867012006e0f0484ba91d48.

The fix broke the sidebar tabs.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.71%. Comparing base (9cb56bd) to head (4f21cd7). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6091 +/- ## ========================================= Coverage 29.71% 29.71% Complexity 914 914 ========================================= Files 287 287 Lines 13835 13835 Branches 2163 2153 -10 ========================================= Hits 4111 4111 - Misses 9409 9410 +1 + Partials 315 314 -1 ``` | [Flag](https://app.codecov.io/gh/nextcloud/calendar/pull/6091/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/nextcloud/calendar/pull/6091/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `15.57% <ø> (ø)` | | | [php](https://app.codecov.io/gh/nextcloud/calendar/pull/6091/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `58.65% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

st3iny commented 1 week ago

I forgot to backport the fix: https://github.com/nextcloud/calendar/pull/6093

Sorry the heat is killing me ... :fire: