search

nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
965 stars 237 forks source link

Overlapping colors in calendar color picker and unused choose button #6145

Closed ChristophWurst closed 1 month ago

ChristophWurst commented 1 month ago

Steps to reproduce

  1. Open the app
  2. Open the edit modal of a calendar
  3. Click the calendar color

Expected behavior

Good design

Actual behaviour

image

Calendar app version

4.8

CalDAV-clients used

No response

Browser

No response

Client operating system

No response

Server operating system

No response

Web server

None

Database engine version

None

PHP engine version

None

Nextcloud version

No response

Updated from an older installed version or fresh install

None

List of activated apps

No response

Nextcloud configuration

No response

Web server error log

No response

Log file

No response

Browser log

No response

Additional info

No response

st3iny commented 1 month ago

For reference, this is how it looks on 29:

Palette Advanced
Bildschirmfoto_20240716_094126 Bildschirmfoto_20240716_094142
ChristophWurst commented 1 month ago

Choose does not do anyhting

It is because of https://github.com/nextcloud-libraries/nextcloud-vue/pull/5499. @susnux I'm not sure how apps should handle the submit event in the simple mode of the color picker. The app can process the selection but it can't close the picker, can it?

st3iny commented 1 month ago

The open state can be controlled from the outside via the shown prop or synced via shown:sync. The prop is currently not documented as it is passed down to NcPopover via v-bind.

So we could add an open state variable showColorPicker to data and listen to the submit event to actually apply the color.

Example

<NcColorPicker :shown.sync="showColorPicker" @submit="setColor">...</NcColorPicker>
ChristophWurst commented 1 month ago

Nice, thank you!