nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
989 stars 240 forks source link

chore: migrate to Vite #6357

Closed GVodyanov closed 1 month ago

GVodyanov commented 2 months ago

Big thanks to @susnux for helping out

Webpack ✨Vite✨
Dev build 45M 7.7M
Production build 19M 3.7M

This is with map files removed

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.48%. Comparing base (8f52c6b) to head (97b4954). Report is 31 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6357 +/- ## ============================================= + Coverage 23.54% 59.48% +35.93% Complexity 454 454 ============================================= Files 247 41 -206 Lines 11700 2231 -9469 Branches 2213 0 -2213 ============================================= - Hits 2755 1327 -1428 + Misses 8624 904 -7720 + Partials 321 0 -321 ``` | [Flag](https://app.codecov.io/gh/nextcloud/calendar/pull/6357/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/nextcloud/calendar/pull/6357/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `?` | | | [php](https://app.codecov.io/gh/nextcloud/calendar/pull/6357/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `59.48% <ø> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

GVodyanov commented 2 months ago

First issue: previewing appointments doesn't have styling

st3iny commented 2 months ago

See also #6068. I don't remember exactly but I fixed some regressions there. You could have a look at the differences.

GVodyanov commented 2 months ago

See also #6068. I don't remember exactly but I fixed some regressions there. You could have a look at the differences.

Yeah... We did this during Ferdinand's workshop and didn't know that you had already done it 😅

GVodyanov commented 1 month ago

Fixed by #6068