nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
989 stars 240 forks source link

feat: disable autocompletion for event property field #6365

Closed kesselb closed 1 month ago

kesselb commented 2 months ago

Motivation:

I just added 8 events to my calendar, and my password manager asked me to unlock the vault for the auto suggestions for every event title. The password manager should do better, but autocompletion for the field seems to have little use and Google Calendar also uses autocomplete off for the event title.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 23.54%. Comparing base (5198e88) to head (cc04b57). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6365 +/- ## ========================================= Coverage 23.54% 23.54% Complexity 454 454 ========================================= Files 247 247 Lines 11700 11700 Branches 2214 2202 -12 ========================================= Hits 2755 2755 - Misses 8624 8625 +1 + Partials 321 320 -1 ``` | [Flag](https://app.codecov.io/gh/nextcloud/calendar/pull/6365/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/nextcloud/calendar/pull/6365/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `15.07% <ø> (ø)` | | | [php](https://app.codecov.io/gh/nextcloud/calendar/pull/6365/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `59.53% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.