nextcloud / calendar

πŸ“† Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
989 stars 239 forks source link

fix(rtl): align event title #6415

Closed hamza221 closed 1 month ago

hamza221 commented 1 month ago

fix #6404 fix #6403

b a
image image
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 23.53%. Comparing base (d039b91) to head (9bc72ad). Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Editor/Properties/PropertyTitle.vue 0.00% 1 Missing :warning:
src/views/EditSimple.vue 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6415 +/- ## ============================================ - Coverage 23.54% 23.53% -0.01% Complexity 454 454 ============================================ Files 247 247 Lines 11701 11705 +4 Branches 2213 2202 -11 ============================================ Hits 2755 2755 - Misses 8625 8630 +5 + Partials 321 320 -1 ``` | [Flag](https://app.codecov.io/gh/nextcloud/calendar/pull/6415/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Ξ” | | |---|---|---| | [javascript](https://app.codecov.io/gh/nextcloud/calendar/pull/6415/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `15.06% <0.00%> (-0.01%)` | :arrow_down: | | [php](https://app.codecov.io/gh/nextcloud/calendar/pull/6415/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `59.53% <ΓΈ> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hamza221 commented 1 month ago

Title has correct position regardless of user input language πŸ‘πŸ» Should the same be applied for links ? image

That's a separate problem 😒