search

nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
989 stars 239 forks source link

fix(rtl): navigation buttons #6416

Closed hamza221 closed 3 weeks ago

hamza221 commented 1 month ago
fix #6402 b a
image https://github.com/user-attachments/assets/e334b714-4049-4367-8f87-aec766020365
hamza221 commented 1 month ago

@DorraJaouad Can you please test this, I'm not sure how it's supposed to work UX wise. I switched the buttons but it feels wrong

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 23.52%. Comparing base (dac1c26) to head (4f88b3c). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...NavigationHeader/AppNavigationHeaderDatePicker.vue 0.00% 11 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6416 +/- ## ============================================ - Coverage 23.56% 23.52% -0.04% Complexity 454 454 ============================================ Files 247 247 Lines 11693 11711 +18 Branches 2205 2221 +16 ============================================ Hits 2755 2755 - Misses 8618 8636 +18 Partials 320 320 ``` | [Flag](https://app.codecov.io/gh/nextcloud/calendar/pull/6416/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/nextcloud/calendar/pull/6416/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `15.06% <0.00%> (-0.03%)` | :arrow_down: | | [php](https://app.codecov.io/gh/nextcloud/calendar/pull/6416/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `59.53% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hamza221 commented 1 month ago

@DorraJaouad are you on latest master (server) ?

DorraJaouad commented 1 month ago

@DorraJaouad are you on latest master (server) ?

No, master is now updated 🙈

The directions should be the opposite (e.g: left side button leads to next month)

https://github.com/user-attachments/assets/9dbd31a8-9d68-4a6c-9c25-108c6c18a297