search

nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
985 stars 239 forks source link

fix: allow adding self to shared event #6418

Closed SebastianKrupinski closed 3 weeks ago

SebastianKrupinski commented 1 month ago

Resolves: https://github.com/nextcloud/calendar/issues/2659

Modified alreadyInvitedEmails result to NOT exclude the current user by default and to only include actual organize and attendees.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.47%. Comparing base (436a9fe) to head (169582d). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Editor/Invitees/InviteesList.vue 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6418 +/- ## ============================================ - Coverage 23.48% 23.47% -0.01% Complexity 454 454 ============================================ Files 247 247 Lines 11705 11708 +3 Branches 2211 2212 +1 ============================================ Hits 2749 2749 - Misses 8636 8639 +3 Partials 320 320 ``` | [Flag](https://app.codecov.io/gh/nextcloud/calendar/pull/6418/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/nextcloud/calendar/pull/6418/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `15.05% <0.00%> (-0.01%)` | :arrow_down: | | [php](https://app.codecov.io/gh/nextcloud/calendar/pull/6418/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `59.42% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

st3iny commented 1 month ago

Do we want to backport this (since the issue is from 2020)? Or is this too risky because of the recent shared calendar changes in server?

SebastianKrupinski commented 3 weeks ago

Do we want to backport this (since the issue is from 2020)? Or is this too risky because of the recent shared calendar changes in server?

We can back port this a few versions.