nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
985 stars 239 forks source link

The Japanese translation incorrect of calendar notification reminders message. #6473

Closed a54758398 closed 1 week ago

a54758398 commented 2 weeks ago

Steps to reproduce

The Japanese translation incorrect of calendar notification reminders message.Minutes are translated into seconds.

English translation:(1 minutes ago) Image

Japanese translation:(1 seconds ago) Image

Please correct the Japanese translation of the calendar notification reminders message.

Expected behavior

Japanese translation:(1 minutes ago)

Actual behaviour

Japanese translation:(1 seconds ago) Image

Calendar app version

4.7.6

CalDAV-clients used

No response

Browser

chrome 130.0.6723.92

Client operating system

Windows10

Server operating system

No response

Web server

None

Database engine version

None

PHP engine version

None

Nextcloud version

29.0.3

Updated from an older installed version or fresh install

None

List of activated apps

No response

Nextcloud configuration

No response

Web server error log

No response

Log file

No response

Browser log

No response

Additional info

No response

miaulalala commented 1 week ago

Which part exactly is wrong? Is it the 1 minute ago part?

@rakekniven is this up your alley?

a54758398 commented 1 week ago

The Japanese translation should take 1 minute ago , not 1 seconds ago .

a54758398 commented 1 week ago

Incorrectly translated code path: https://github.com/nextcloud/server/blob/v29.0.3/apps/dav/l10n/ja.json#L65

rakekniven commented 1 week ago

Changed it seconds ago to "%1分钟".

That string was wrong since 5 years. Glad you reported it.

Bye

a54758398 commented 1 week ago

Incorrectly Japanese translation: https://github.com/nextcloud/server/commit/397885adfadaf83434d032a250cb11260c66cad3#diff-f54f386ef9b12e71145167376c976ac276e7967107b7d82450406f82a2b1ce3bR67 Correct Japanese translation: "%n minute::%n minutes" : ["%n分"], Thanks.

rakekniven commented 1 week ago

@a54758398 What do you mean with your latest comment? Did I make the correct change?

a54758398 commented 1 week ago

Please see the image below: Image Image

rakekniven commented 6 days ago

Thanks, should be ok now.