nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
985 stars 239 forks source link

Move edit sidebar into a modal #6488

Open GVodyanov opened 1 week ago

GVodyanov commented 1 week ago

Fix https://github.com/nextcloud/calendar/issues/6378

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 9.21053% with 69 lines in your changes missing coverage. Please review.

Project coverage is 23.51%. Comparing base (7fb8727) to head (35e2de4). Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
src/views/EditFull.vue 0.00% 62 Missing :warning:
src/components/Editor/Properties/PropertyTitle.vue 0.00% 3 Missing :warning:
src/mixins/EditorMixin.js 33.33% 0 Missing and 2 partials :warning:
src/components/CalendarGrid.vue 0.00% 1 Missing :warning:
src/views/EditSimple.vue 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6488 +/- ## ============================================ + Coverage 23.48% 23.51% +0.03% Complexity 453 453 ============================================ Files 247 247 Lines 11716 11704 -12 Branches 2212 2217 +5 ============================================ + Hits 2751 2752 +1 + Misses 8645 8632 -13 Partials 320 320 ``` | [Flag](https://app.codecov.io/gh/nextcloud/calendar/pull/6488/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/nextcloud/calendar/pull/6488/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `15.07% <9.21%> (+0.02%)` | :arrow_up: | | [php](https://app.codecov.io/gh/nextcloud/calendar/pull/6488/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | `59.37% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

GVodyanov commented 13 hours ago

It was decided that this will be finished later