nextcloud / circles

👪 Create groups with other users on a Nextcloud instance and share with them
GNU Affero General Public License v3.0
142 stars 47 forks source link

App icon is inverted on app management #1232

Open nickvergessen opened 1 year ago

nickvergessen commented 1 year ago

The default icon should be a white icon.

In order to still have a working icon for notifications/activities/other usages, the black version should be added as img/circles-dark.svg and be used in those places instead:

Current

Bright Dark
Bildschirmfoto vom 2023-01-02 10-55-07 Bildschirmfoto vom 2023-01-02 10-54-30
Jerome-Herbinet commented 1 year ago

@nickvergessen, it seems that by default (at least in light theme, but it seems to be the same in dark theme ... a bit strange), the icons are white (or whatever light colour) and that, also by default, a CSS property is applied to revert colour. So as far as I understand how it works, we don't need to create a circles-dar.svg, and we just need to turn "light" the circles.svg icon ; then it will fit standard app icon display. I'll have a look at it. The only thing I ignore is that I don't know if this will cause side effects elsewhere in the Circle app.

nickvergessen commented 1 year ago

A circles-dark is needed for all other places (activities, notifications, etc.) once circles.svg is light. That is how all other apps do it, so circles should follow

Jerome-Herbinet commented 1 year ago

Calendar

There are many icons, in different file types. Of course each of them is (or is supposed to be) useful, but in the app list, in both light and dark theme, the used file is calendar.svg with CSS properties depending on the case (colour invert, opacity). 2023-05-26_15-15 Image : https://nextcloud.herbinet.fr/apps/calendar/img/calendar.svg The other apps like "Contact" work the same. Only some apps with the gear icon work differently.

Circles

Only one icon exists, and it's exactly called and used as it's equivalent for Calendar. So I propose at least to replace this icon by the same, but dark so that it should work as for Calendar. What do you think. 2023-05-26_15-16 Image : https://nextcloud.herbinet.fr/apps/circles/img/circles.svg

Do you think that "truth is elsewhere" like in X-Files ? 🙂

thgoebel commented 1 year ago

The same issue is also present in the "Shared to Circle" sidebar entry of the Files app. Note that the icon is not inverted, it is always dark.

image