Open dtygel opened 6 years ago
@viniciuscb
About the Circles API, I know it is missing a function to retrieve the list of the shared items (circles_shares), I think nothing read the information listed in that database right now, and I will work on this.
However this will not be necessary in here.
If you start working on the files from Nextcloud, maybe adding a entry on the left menu:
A 'shared by ...' entry that allow your users to filter the file shared by another user, a group or a circle. This way you use directly the ShareProvider as the shares for the files are in oc_shares and not oc_circles_shares
This would be an interesting feature.
(Are we talking about the same thing in fact ? ;p)
The API to get item shared from a Circle, in 2 versions, safe and not safe: https://github.com/nextcloud/circles/pull/139
But I am sure it is not needed for this feature.
@dtygel I still like the idea, any update ? :)
@daita Yes! We have a working code, but haven't done the tests yet. If you'd like to see how it's going, we can make a PR, still without the tests. What do you think?
Sure, please do. This would be great for NC13
Above are the 3 commits that make the files' panel work. The first one is in core. The second and third ones are in circles' plugin.
We'll do both PRs this week or on Monday for your review.
Wow, this is nice.
I am cleaning few stuff and I will PR on your fork, but can you please rebase on your side ?
Cool that you liked it, @daita . We'll then rebase now to master
so that you can create the PR and do the cleanings. Our branch was based on stable12, so we'll create another one.
I don't think I am able to PR on your fork, so this is my work about this:
https://github.com/nextcloud/circles/tree/edit-files-panel
https://github.com/coletivoEITA/circles/pull/2
cleaner, without the merge mess.
We tested, everything seems fine. Great job!! Should we do a PR of this to circles?
Um abraço!
:+1:
please, make the PR for circles and nextcloud
@viniciuscb can you check if the integration of this feature is still working on your side ? it seems to be buggy on NC13 and NC14 !
Obrigado
Today, the file list view allows users to filter files by tags, but there is no way to list files per circle(s).
We are working on a PR to do this. For this to be possible, we will also need to make a PR to NextCloud Core, including the needed infrastructure in
core/js/files/client.js
and inapps/dav/lib/Connector/Sabre/FilesReportPlugin
.Our solution involves the creation of a new Method in Circles API V1, which we called
getObjectIdsForCircles
, and uses another new method, in ShareByCirclesProvider, which retrieves the shares by Circles's Unique Ids.