search

nextcloud / circles

👪 Create groups with other users on a Nextcloud instance and share with them
GNU Affero General Public License v3.0
142 stars 47 forks source link

fix/remove broken scripts #1521

Closed juliushaertl closed 6 months ago

juliushaertl commented 6 months ago

We need to migrate those scripts to the new files API but this is more work there is currently no time. It seems those scripts can cause failures as reported in https://github.com/nextcloud/circles/issues/1434

As they don't work right now there is no need to load them and this also has been a regular annoyance when running cypress tests locally where the random console errors cause failures.

Left the script files in place to know what to implement with the new API.

VGerris commented 6 months ago

Just some comments, thanks for linking to the other issue. What do you mean with no time ? As in lower priority? If anyone has a good quick getting-starting to developing that part, I might give it a shot. Perhaps good to rename those scripts with something in the name indicating they need to be reimplemented or removed , like filename.a -> filename-disabled-needs-api-impl-ticket1521.a or something. And also good to determine impact of this, it may be quite serious and as such be more priority than initially thought. Thank you!