search

nextcloud / client_theming

:computer: Nextcloud themed desktop client - Moved over to https://github.com/nextcloud/desktop
GNU General Public License v2.0
198 stars 87 forks source link

Changelog generator script fix #227

Closed ivaradi closed 6 years ago

ivaradi commented 6 years ago

Even though the current code is already tagged v2.3.3, the changelog script currently considers it a beta release, because the same commit to which v2.3.3 is applied is also pointed to by the v2.3.3-beta2 tag.

This commit fixes the changelog generator script to handle this situation.

ivaradi commented 6 years ago

Only the AppImage build fails due to reasons unrelated to this change.

enoch85 commented 6 years ago

Looks fine to me, still would want a second opinion on the Appimage stuff though @probonopd

probonopd commented 6 years ago

Looks fine to me, still would want a second opinion on the Appimage stuff though @probonopd

Most likely https://github.com/AppImage/AppImages/#warning-important-notice

I think @rullzer uses a different (better) way of making AppImages these days, though (using linuxdeployqt)?

ivaradi commented 6 years ago

Could anyone, please, approve this change?

enoch85 commented 6 years ago

@ivaradi What about the failing test?

ivaradi commented 6 years ago

It fails in the AppImage build, which I am not familiar with. Maybe its author could check it, or we could disable it. (I can also check, but I am not familiar with AppImage or the building process, so it would not happen too soon :) )

probonopd commented 6 years ago

@rullzer can you have a look at this please? Is this way of building the AppImage even what you still use?