nextcloud / cms_pico

🗃 Integrate Pico CMS and let your users manage their own websites
https://apps.nextcloud.com/apps/cms_pico
GNU Affero General Public License v3.0
134 stars 41 forks source link

Upstream/pico3 #232

Open derMart opened 1 year ago

derMart commented 1 year ago

As discussed in https://github.com/nextcloud/cms_pico/issues/218 here is a pull request to upstream to Pico 3.

I had to remove incompass/coverage composer package as this was causing incompatibilities with current symfony packages. Maybe an alternative need to be found for this. However, as I did not get tests to execute anyway (see https://github.com/nextcloud/cms_pico/issues/231) this might be fixed in the future anyway.

harrysummer commented 1 year ago

API_VERSION_4 also needs to be added here:

https://github.com/derMart/cms_pico/blob/7787b36318e471bc59ca14261823933a1374a79a/lib/Model/Theme.php#L51

derMart commented 1 year ago

@harrysummer thanks alot! I've added the change