Make it work with NC 26

nextcloud / cms_pico

🗃 Integrate Pico CMS and let your users manage their own websites

https://apps.nextcloud.com/apps/cms_pico

GNU Affero General Public License v3.0

134 stars 41 forks source link

Make it work with NC 26 #236

Open GVLLIFESTYLE opened 1 year ago

GVLLIFESTYLE commented 1 year ago

Hello!

It would be nice if it would work on NC 26 and php 8.2 as well. The Admin Page like Themes,... is not working there anymore.

best regards

Patrick

Uatschitchun commented 11 months ago

This would be NC27 now...

EdG973GCS commented 11 months ago

OK for hacky workaround. But PICO CMS users would appreciate an update for NC 26 and above. It is so stressful to get our pico pages not working after each new NC version deployment.

GVLLIFESTYLE commented 11 months ago

I agree

Am 31. Juli 2023, 21:10, um 21:10, EdG973GCS @.***> schrieb:

OK for hacky workaround. But PICO CMS users would appreciate an update for NC 26 and above. It is so stressful to get our pico pages not working after each new NC version deployment.

-- Reply to this email directly or view it on GitHub: https://github.com/nextcloud/cms_pico/issues/236#issuecomment-1658982624 You are receiving this because you authored the thread.

Message ID: @.***>

PhrozenByte commented 11 months ago

Pull request on the cms_pico-1.0 branch is welcome :+1:

jkraffthha commented 8 months ago

Pull request on the cms_pico-1.0 branch is welcome 👍

Fix is on the way, I've made a pull request.

khassad commented 5 months ago

Hi, any news on NC 26+ compatibility ?

DivineDominion commented 5 months ago

@PhrozenByte Is this still an issue or can this be closed?

jkraffthha commented 5 months ago

@PhrozenByte Is this still an issue or can this be closed?

My fix has been commited to the 1.0 branch, I don't know what's missing for it to get to the Nextcloud App Store...

DivineDominion commented 5 months ago

The cms_pico-1.0 branch? https://github.com/nextcloud/cms_pico/tree/cms_pico-1.0

I guess this needs to be merged into the main branch before the App Store picks this up at the very least. 🤔

horga83 commented 4 months ago

Any movement about getting this into the NC27 app store?

StCyr commented 4 months ago

@DivineDominion, @jkraffthha,

I don't find the PR, where is it?

jkraffthha commented 4 months ago

@DivineDominion, @jkraffthha,

I don't find the PR, where is it?

Here: https://github.com/nextcloud/cms_pico/pull/242

miguelsan commented 3 months ago

My fix has been commited to the 1.0 branch, I don't know what's missing for it to get to the Nextcloud App Store...

Well, now we have an answer to that:

[...] run a manual app install (see README.md) from the cms_pico-1.0 branch (use git clone -b cms_pico-1.0 https://github.com/nextcloud/cms_pico.git apps/cms_pico) on a fresh Nextcloud instance running stable versions 26, 27 and 28 [...] including manual testing of all the app's basic functionality.

Can anybody confirm that it has been successfully tested in this way?

miguelsan commented 2 months ago

Now the need for a solution has become urgent!

At my install, I get the following under Administration settings:

Version
25.0.13

Update
  The version you are running is not maintained anymore. Please make sure to update to a supported version as soon as possible.
A new version is available: Nextcloud 26.0.13
1 app has no compatible version for this Nextcloud version available.
Apps missing compatible version
  Pico CMS

Any news on advancements?

noci2012 commented 2 months ago

And currently there is Nextcloud 29..... making 26 even obsolete.

In 29 the argument list for class creator is slightly different.

PhrozenByte commented 2 months ago

In 29 the argument list for class creator is slightly different.

Pull request to be merged into the cms_pico-1.0 branch are welcome. If someone then tests everything (see #242) I'm still down to a release...

noci2012 commented 1 month ago

That might be easy to someone already working with all the stuff, not so much NC actually. Documentation missing, misdirecting inconsistent etc, I guess i have to take this as a statement of obsolesence and deprecation for cms_pico as one of the next apps fallen into the gutter.

noci2012 commented 1 month ago

installing pico-1.0 from github does work in 29. There is a warning about using deprecated appinfo/app.php.

Just migrating the code there to lib/AppInfo/Application.php gives other errors n some Http.php library. Still the webpages do render.

GVLLIFESTYLE commented 1 month ago

With version 29. I have the issue, that my the settings-page of the user shows only 1 active site intsead of all of them + you can't change any settings anymore. The error:

/appinfo/app.php is deprecated, use \OCP\AppFramework\Bootstrap\IBootstrap on the application class instead.