nextcloud / contacts

📇 Contacts app for Nextcloud
https://apps.nextcloud.com/apps/contacts
GNU Affero General Public License v3.0
569 stars 173 forks source link

Company Saved as Contact Name (webdav iOS) #1083

Closed sknsean closed 5 years ago

sknsean commented 5 years ago

Describe the bug

When adding a company name to a contact the name is removed and the company is displayed.

To Reproduce Create a new contact, add company name

Expected behavior The First and Last should be kept and the company name added as a company name.

Actual behavior Only the company name is synced

Screenshots nextcloudcontacts IMG_0835

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/73575941-company-saved-as-contact-name-webdav-ios?utm_campaign=plugin&utm_content=tracker%2F46751899&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F46751899&utm_medium=issues&utm_source=github).
sknsean commented 5 years ago

possibly related to #986 #165 #848

sknsean commented 5 years ago

vcf from contact created in nextcloud: BEGIN:VCARD VERSION:3.0 PRODID:-//Sabre//Sabre VObject 4.1.6//EN UID:701932cf-5f16-4114-8894-ca9701b3838f REV;VALUE=DATE-AND-OR-TIME:20190501T113643Z FN:Jens Jensen ADR;TYPE=HOME:;;;;;; EMAIL;TYPE=HOME:jens@jensenc.dk TEL;TYPE="HOME,VOICE":+4580808080 ORG:Consultantcompany END:VCARD

skjnldsv commented 5 years ago

Hello :) If I understand correctly, you expect to have Jens Jensen displayed on your iOS device?

sknsean commented 5 years ago

Yes exactly :-) There is also an extra " before the "HOME" number. IMG_0836 As seen here the First and Last name is empty

skjnldsv commented 5 years ago

This is an iOS issue then. If you look at your contact vcard, you'll see that the FN property is still set with the proper data. iOS have just decided to display the ORG instead.

First name and Last name are empty because you never set it on nextcloud. You need to add a detailed name property (N) on nextcloud. FN is the display name, and your device seems to ignore it if ORG is set :wink:. But I still don't know if iOS will prefer displaying the ORG or the N property then. Please try and report back :)

For the " in front of home, this is also an iOS issue unfortunately. This is correct, a vcard can have a TYPE="home,voice" data set, but iOS is somehow not properly displaying it :thinking: Can you try

sknsean commented 5 years ago

Vcf when Contact is created from iOS BEGIN:VCARD VERSION:3.0 PRODID:-//Apple Inc.//iOS 12.2//EN N:Nielsen;Niels;;; FN:Niels Nielsen ORG:FishingCompany; EMAIL;type=INTERNET;type=HOME;type=pref:niels@fish.eu TEL;type=HOME;type=VOICE;type=pref:44 74 74 74 REV:2019-05-01T14:08:13Z UID:BE3309BE-0E6B-4F17-BD4B-F1E2DBBDA6F1 END:VCARD

Hehe, it’s not easy to fix things in iOS ;-). Will try to set first and last name, later and report back

skjnldsv commented 5 years ago

Vcf when Contact is created from iOS

and it's properly displayed in iOS? If so then it's fine, but you should know that you will need to use the detailed name property and not only the display name one :)

sknsean commented 5 years ago

Yes it's properly displayed. It's also properly displayed when setting first and last name in nextcloud. Would it be difficult to change (aka. more difficult than to convince Apple to comply with the standard): TEL;TYPE="HOME,VOICE": to TEL;type=HOME;type=VOICE:

skjnldsv commented 5 years ago

Issue is that if we do so, we might also lose compatibility with other softwares/platforms :) Also I think the library we use for that is bugged and does not support it properly. https://github.com/mozilla-comm/ical.js/issues/343

ghost commented 5 years ago

1107 for the VCF format.

I've brought up the company name issue before. Didn't end well.

ghost commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

ghost commented 5 years ago

Not stale. No missing information. Fix needed.

1107 for the VCF format.

skjnldsv commented 5 years ago

Sorry, forgot to remove the needs info label :) Though closing since for multiple types we have this: https://github.com/nextcloud/contacts/issues/942 And for the various vcf formats #1107

And regarding the FN/N misconception, well, that's how vcards works :man_shrugging: :)