search

nextcloud / contacts

📇 Contacts app for Nextcloud
https://apps.nextcloud.com/apps/contacts
GNU Affero General Public License v3.0
569 stars 173 forks source link

XMPP schema #1609

Open sualko opened 4 years ago

sualko commented 4 years ago

Describe the bug

If you add an XMPP address to a contact the resulting link is missing the xmpp: schema

To Reproduce Steps to reproduce the behavior:

  1. Select any contact
  2. Add property of type instant messenging
  3. Select XMPP as messenger
  4. Add jid
  5. click on "open external" icon inside the input

Expected behavior xmpp: link is rendered.

Actual behavior https: link is rendered

Possible solution It's probably a one line change here: https://github.com/nextcloud/contacts/blob/b47082b0baf162be7647399276432054856b7716/src/components/Properties/PropertyText.vue#L153

Screenshots 2020-04-30 11 51 30 localhost 36a37efd80ff 2020-04-30 11 51 57 localhost 9cec6033384e

Server configuration

PHP version: 7.3

Nextcloud version: 19 beta 2

Contacts version: 3.3.0

ref nextcloud/jsxc.nextcloud#143

rexTexTau commented 11 months ago

Hello nextcloud dev team! This bug is easily reproducible at the moment. I want to fix it, as well as related bugs of that sort (for example, Telegram link is rendered as https://username instead of https://t.me/username). Please do assign it to me to prevent other devs' been working on same thing (yep, I could make a pull request wo assignation, but it'll be more duplicate-work-proof)

ChristophWurst commented 11 months ago

Go ahead @rexTexTau. Others will see your comment here and know that you are working on this :+1:

rexTexTau commented 9 months ago

@ChristophWurst Seems like README.md misses some essential documentation for developers that are new to NextCloud project.

Long story short: 1) I've installed a fresh clean Ubuntu (do NOT TRUST Microsoft that assures you that Docker works on Windows - [s]the cake[/s] it's a lie, it may seem be working at a first glance, but significally damages overall OS functionality, for example, drastically slows down network connection speed, so I recommend to never ever install Docker on Windows based on my personal 3-hour googling experience and completely reverting the installation after it). 2) I've successfully installed Docker on it and ran the Nextcloud dev container (related manual on nextcloud.com is great, thank you). 3) I've successfully installed dev packages required to build the app (node, typescript, etc). It will be useful to have actual factual bash command sequence in readme.MD (one or two hours of googling did the trick, but it will be really helpful - I'd better use that time to actually fix the bug). 4) I've successfully built the app in all possible described manners (npm run build, npm run dev, npm run tests). But at this step I'm really stuck trying to connect the dots: a) Where does the build script places the actual output? b) How do I place this output into the Nextcloud dev docker container? Should I use nextcloud.local/index.php/settings/apps/feautured/contacts [Download and Enable] button? If yes, how do I specify the download source (local instead of network)? If there is no way to install locally built Contacts using this button, should I first install Contacts from network, and then somehow overwrite it by the local copy? If yes, how do I safely and reliably do this? c) Then, after somehow placing the Contacts code into Docker container, how do I debug (using VSCode or other popular modern IDE)?

Any help will be greatly appreciated. I feel very frustrated doing 10h+ (and counting) local dev environment installation and customization in order to fix a one-liner (actually I suppose it'll be a 10-liner bugfix or so, but this does not change the main idea), but hope to receive a helpful advice. Any help would be appreciated. And I really, really wish the documentation to be more detailed, especially for new-to-nextcloud developers.