nextcloud / contacts

📇 Contacts app for Nextcloud
https://apps.nextcloud.com/apps/contacts
GNU Affero General Public License v3.0
569 stars 172 forks source link

Imported Google Contacts adds "\" before a "," within a phone number (Please support the "," character) #1855

Open Oclair opened 4 years ago

Oclair commented 4 years ago

Hi there,

I have a voice over IP provider whom I call locally to make international calls.

So I have setup in my contacts a "," which causes a 2 second pause so my VOIP provider can recieve the number I actually wish to call. for example the VOIP number is +99 1 5551212 and the number I wish to call is +1 202 555 1212. Therefore the contact uses the following number +9915551212,0012025551212 The imported contact instead now has +9915551212\,0012025551212

this "\" character is often used in PHP and HTML as a breakout character in coding and certainly should not be present within the telephone number for each imported contact.

the comma is an appropriate character for a telephone number within an addressbook

I cannot know how each implementation of my contacts will interpret this added character "\" it is not the data which should have been imported and indicates that the developer who coded the import function written in PHP does not expect a comma present within a telephone number

Nextcloud 19.0.4 Contacts 3.4.0 OS installed and updated on FreeBSD manually via CLI using the standard Nextcloud.com stable Channel

Please ping me when "," support has been added to this plugin so I can again re-import my contacts!

Thank you for the awesome work and contributions to the community! OC

GoogleContactExportSamplesWithCommaInTelephoneNumber.zip

Oclair commented 4 years ago

This Behavior occurred when importing a .vcf file generated by Google under the Export contacts feature for Contacts using the vCard (for iOS Contacts) format. I have updated the issue to include a sample with the 3 different export formats generated from a single contact.

Oclair commented 4 years ago
BEGIN:VCARD
VERSION:3.0
FN:Nextcloud GitHub
N:GitHub;Nextcloud;;;
item1.TEL:+43 5551 212\,0012025551212
item1.X-ABLabel:
item2.ORG:Contacts
item2.X-ABLabel:
CATEGORIES:myContacts
END:VCARD!

Screenshot: https://i.ibb.co/RBKWmZV/Screenshot-2020-10-16-185938.jpg Screenshot-2020-10-16-185938

Attempting to export that contacts generates a breakout for the comma in the phone number in the exported file.

stefan123t commented 4 years ago

Same problem may occur with other special chars like # and * used for providing Telco details like conference room and/or password. Thanks for considering these too.

I researched and found the following RFC 6868 on escaping rules between iCalendar and vCard which may apply.

RFC 6868 Parameter Value Encoding in iCalendar and vCard https://tools.ietf.org/html/rfc6868

joshtrichards commented 10 months ago

Partially blocked on a new upstream release of ical.js: kewisch/ical.js#646

joshtrichards commented 7 months ago

New ical.js release is out: https://github.com/kewisch/ical.js/releases/tag/v2.0.0

joshtrichards commented 5 months ago

v26 ical.js has been merged: #3941