search

nextcloud / contacts

📇 Contacts app for Nextcloud
https://apps.nextcloud.com/apps/contacts
GNU Affero General Public License v3.0
570 stars 173 forks source link

Create shortcuts and place them into settings #2827

Open JuliaKirschenheuter opened 2 years ago

JuliaKirschenheuter commented 2 years ago

Is your feature request related to a problem? Please describe.

Accessibility issue.

Please create shortcuts for contacts and place them into settings (like in Mail or Calendar app).

Some shortcuts (especially character key shortcuts) can interfere with shortcuts used by some assistive technologies. Please make sure that the shortcuts don’t interfere with screen reader commands (NVDA, Jaws, Orca).

See more here https://www.w3.org/TR/WCAG21/#character-key-shortcuts https://webtest.bitv-test.de/index.php?a=di&iid=269&s=n

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

nickvergessen commented 2 years ago

Server PR for a global setting to opt out of keyboard shortcuts to satisfy accessibility is in:

Method to check: OCP.Accessibility.disableKeyboardShortcuts()

If that is true the app(s) must not register ANY shortcuts.

ChristophWurst commented 2 years ago

Initial state to check is: loadState('theming', 'shortcutsDisabled', false)

Can we have some kind of API for this? Feels a bit strange to me if we fetch an initial state of another app.

nickvergessen commented 2 years ago

Can we have some kind of API for this?

Anything you have in mind? Yet another package, or just a global function in server/core which then relies on the initialstate?

ChristophWurst commented 2 years ago

Whatever makes this an official API that we can document. But I see that there is no time to address this properly at the moment.

nickvergessen commented 2 years ago

OCP.Accessibility.disableKeyboardShortcuts() was added as discussed in the chat