search

nextcloud / contacts

📇 Contacts app for Nextcloud
https://apps.nextcloud.com/apps/contacts
GNU Affero General Public License v3.0
571 stars 172 forks source link

Hide "Allow updating avatars from social media" when internet access is disabled #2914

Open pboguslawski opened 2 years ago

pboguslawski commented 2 years ago

Is your feature request related to a problem? Please describe.

If system has connection to internet disabled by admin, syncing data with social services should be disabled too.

Describe the solution you'd like

Consider hiding Allow updating avatars from social media option in admin settings > Groupware > Calendar if has_internet_connection is false in config.php for cleaner UI.

PR https://github.com/nextcloud/contacts/pull/2913 already disables cron job and user setting in such scenario.

Describe alternatives you've considered

No response

Additional context

No response

call-me-matt commented 2 years ago

I personally would feel confused if certain settings do not show up in different setups. Maybe more a question to the design team.

pboguslawski commented 2 years ago

I personally would feel confused if certain settings do not show up in different setups.

There are already other suboptions that are hidden if parent option is disabled. Less unnecessary options, less mess IHMO.