nextcloud / contacts

📇 Contacts app for Nextcloud
https://apps.nextcloud.com/apps/contacts
GNU Affero General Public License v3.0
564 stars 169 forks source link

Hide empty fields of structured properties (e.g. address, detailed name) #3412

Closed ChristophWurst closed 1 year ago

ChristophWurst commented 1 year ago

Is your feature request related to a problem? Please describe.

The app renders all part of a structured property like ADR in view mode

Bildschirmfoto vom 2023-05-26 08-51-54

image

Describe the solution you'd like

Hide the parts in view mode, only show in edit mode

image

(Other is the type of the address. Like Home vs Work vs Other. It's placement is topic of another discussion)

Describe alternatives you've considered

No response

Additional context

@jancborchardt @marcoambrosini @nimishavijay do or don't?

ChristophWurst commented 1 year ago

@jancborchardt @marcoambrosini @nimishavijay do or don't?

I'll go ahead and assume you'll approve this

jancborchardt commented 1 year ago

Yeah definitely hiding looks better. Best would be to put it in a readable single line form when in view mode, so not:

First name: Christine Last name: Schott

But just:

Christine Schott

Same for address.

Or do we run into issues there because we do not know which format the names and addresses of the locale have? (And have no way to define it?)

jancborchardt commented 1 year ago

Or do we run into issues there because we do not know which format the names and addresses of the locale have? (And have no way to define it?)

Is there any list of name and address formats of various locales we could use? Or we might have to just add it ourselves. E.g. saying for Hungarian and Japanese, use Last Name First name, etc etc. Same for address formats.

ChristophWurst commented 1 year ago

Let's take baby steps and hide empty parts as a start

JohannesGGE commented 1 year ago

Should already be done by https://github.com/nextcloud/contacts/pull/3422