Export randomly escapes commas, and converts spaces into escaped commas, causing 3rd-party clients to render them as ",".

RokeJulianLockhart commented 5 months ago

Describe the bug

Export of a contact converts spaces in its prefix into \,, causing 3rd-party clients to render what should be spaces as ",".

Steps to reproduce

Create a contact with a prefix which contains spaces.
Export it to a .VCF.
Delete the contact in the database.
Import the .VCF.
Synchronize the address book via https://github.com/bitfireAT/davx5-ose/releases/download/v4.4.0.1-ose/davx5-ose-4.4.0.1-ose-release.apk.
View the contact via https://github.com/FossifyOrg/Contacts/releases/download/1.0.1/contacts-2-foss-release.apk.

Expected behavior

The prefix should render as "WordOne WordTwo".

Actual behavior

The prefix renders as "WordOne,WordTwo".

Contact version

Unknown, but at most, https://github.com/nextcloud/contacts/releases/tag/v5.0.1.

Operating system

cpe:/o:canonical:ubuntu

PHP engine version

None

Web server

nginx/1.18.0

Database

{"needsDbUpgrade": false} // https://wim.nl.tab.digital/status.php

Additional info

No response

hamza221 commented 4 months ago

This is what I tried and couldn't reproduce

Create contact John Doe
Export contact
Delete it
Import it.
still John Doe

RokeJulianLockhart commented 4 months ago

https://github.com/nextcloud/contacts/issues/3985#issuecomment-2200283644

@hamza221, that's not descriptive enough for me to advise you on - what fields specifically did you fill, and what with? As an example, if you just put the N as N:Doe;John;;;, indeed that's not going to work, because you've not used the prefix section.

However, it appears that my initial conclusion that this consistently and solely affected the prefix section was incorrect, for I can export some .VCFs without a space in the prefix causing the space to be escaped. Regardless, I can still reproduce this with some contacts:

BEGIN:VCARD
VERSION:3.0
PRODID:-//Sabre//Sabre VObject 4.4.2//EN
UID:2750273e-c364-4c25-b92c-aae2e3ed6efe
FN:REDA REDACTE
N:REDACTE;REDA;;Junior\,Soldier;
ORG:HM Armed Forces
TITLE:NATO STANAG 2116 OR-2
TEL;TYPE=cell:+44-0000-000000
EMAIL;TYPE=home:@ArmyMail.MOD.UK
REV;VALUE=DATE-AND-OR-TIME:20240702T160920Z
END:VCARD

I've replaced the lad's actual name with "REDACTED" concatenated to the exact length of his original name. I have to, for his sake. I can't imagine that the actual characters matter much anyway.

In trying to diagnose this, I've noticed that it affects more fields, too, like NEXTCLOUD1.TEL - below is an example exported .VCF:

BEGIN:VCARD
VERSION:3.0
PRODID:-//Sabre//Sabre VObject 4.4.2//EN
UID:7b002174-34ac-4efb-ba9b-474e8687e111
FN:Example First Example Last
N:Example Last;Example First;Example Middle;Example Prefix;Example Suffix
NICKNAME:Example Nickname
ORG:Example Organization
NEXTCLOUD1.TEL:+44-1234-123456\,123
NEXTCLOUD2.EMAIL;TYPE=home:example+example@example.com
URL;VALUE=URI:ftp://example:example@example.com
URL;VALUE=URI:HTTPS://example:example@example.cpm
NEXTCLOUD3.ADR;TYPE=home:Example Post Office Box;Example Extended Address;E
 xample Address;Example City;Example State or Province;Example Postcode;Exa
 mple Country
NOTE:HTTPS://WWW.markdownguide.org/extended-syntax/\n\n<blockQuote>\n\n| Sy
 ntax      | Description | Test Text     |\n| :---        |    :----:   |  
       ---: |\n| Header      | Title       | Here's this   |\n| Paragraph  
  | Text        | And more      |\n\n```\n{\n  "firstName": "John"\,\n  "la
 stName": "Smith"\,\n  "age": 25\n}\n```\n\nHere's a simple footnote\,[^1] 
 and here's a longer one.[^bignote]\n\n[^1]: This is the first footnote.\n\
 n[^bignote]: Here's one with multiple paragraphs and code.\n\n    Indent p
 aragraphs to include them in the footnote.\n\n    `{ my code }`\n\n    Add
  as many paragraphs as you like.\n\n### My Great Heading {#custom-id}\n\nF
 irst Term\n: This is the definition of the first term.\n\nSecond Term\n: T
 his is one definition of the second term.\n: This is another definitionof 
 the second term.\n\n- [x] Write the press release\n- [ ] Update the websit
 e\n- [ ] Contact the media\n\nGone camping! :tent: Be back soon.\n\nThat i
 s so funny! :joy:\n\nI need to highlight these ==very important words==.\n
 \nH<sub>2</sub>O\n\n`HTTPS://WWW.example.com`\n\n</blockQuote>
REV;VALUE=DATE-AND-OR-TIME:20240702T160410Z
TITLE:Example Title
NEXTCLOUD1.X-ABLABEL:Example Label
NEXTCLOUD2.X-ABLABEL:Example Label
NEXTCLOUD3.X-ABLABEL:Example Label
X-PHONETIC-FIRST-NAME:Example Phonetic First Name
X-PHONETIC-LAST-NAME:Example Phonetic Last Name
GEO;VALUE=URI:geo:90.000\,0.000
RELATIONSHIP:ASSISTANT
TZ:Europe/London
X-MANAGERSNAME;UID=e1f2ec5c-074e-4875-ac62-53ff24770ffa:Roke Beedell
END:VCARD

Notice NEXTCLOUD1.TEL:+44-1234-123456\,123. The comma is the standard extension denotation syntax, and definitely wasn't escaped by myself - that's the work of the exporter.

nextcloud-command commented 1 week ago

Hi there! It looks like this issue hasn’t seen much activity for a while and might need a bit more information to move forward. If we don’t hear back soon, we may close it to keep things organized. Thanks again for your contributions – we really appreciate it!

nextcloud / contacts