nextcloud / cookbook

🍲 A library for all your recipes
https://apps.nextcloud.com/apps/cookbook
GNU Affero General Public License v3.0
522 stars 89 forks source link

Edit keywords #682

Open fab920 opened 3 years ago

fab920 commented 3 years ago

Is your feature request related to a problem? Please describe. When one imports a recipe from an url, keywords are imported as well. Over time I got a lot of different keywords, some are English, some are German. Some are with " , some are without. And a lot of them are just not helpful at all.

Now I would like to clean them up. But the only way I found to do so is by going threw all recipes, remove them and create new ones as needed.

Describe the solution you'd like A way to rename and delete keywords. Optional merge two keywords (like "Vegan" and Vegan)

Describe alternatives you've considered

christianlupus commented 3 years ago

Just out of curiosity: The quotes should not be there unless the schema.org data (aka the JSON included) is partly broken. Could you please look for one recipe with a tag Vegan and one with a tag "Vegan". Then could you send the corresponding JSON files from the files app to us (attach here, send via mail or via matrix chat)? Just to make sure, we have no bug in the parsing routines. This is obviously no direct solution to the feature request but might reduce the amount of problems.

saschabrockel commented 2 years ago

I'm looking for the same feature but when the issue is already open since April I guess we won't get this feature in near future.

Bugsbane commented 2 years ago

@saschabrockel I'm looking for the same feature, too, but I'd suggest just clicking on the Thumbs up on the original post, or helping out (coding, paying someone to code, triaging issues or helping with documentation so the devs have more time to address most upvoted features).

This project is built on contributions, so if you'd like to see something happen, find a way to help the devs, whether you know how to code or not. Wearing them down with comments like "I guess we won't get this feature in near future" is likely to just reduce their motivation rather than helping the cause.

bluszcz commented 2 years ago

I clicked the 👍 :), for instance it is annoying that I can't change 'falafel' to 'Falafel'...

I would consider work on this feature, but how to ensure that nobody did some work for now?

seyfeb commented 2 years ago

@bluszcz If you would like to start the development, I can assign you to this issue. Since nobody mentioned he would start working on this, from my experience, the chances are pretty high, that nobody has ;)

TheMBeat commented 2 years ago

Hey @seyfeb, i didn't work on it. So I think you can assign @bluszcz to this issue would be great.

bluszcz commented 2 years ago

Ok, I am setting these days up the development environment. I am still having some issue with the reverse proxy (php -S is way too slow), but i should get there soon :)

christianlupus commented 2 years ago

@bluszcz If you need help with the dev env you can contact me. BTW, why are you in need of a reverse proxy?

bluszcz commented 2 years ago

Hi @christianlupus thanks for the help offered, but I sorted it out. I managed to set up an environment and now I am playing around with the Vue templates, Nextcloud components and architecture of the cookbook app (the Icon Edit in Breadcrumb after "Falafel" is my edit already).

image

I am using nginx as reverse proxy, since php one thread development server was much way too slow (i was waiting minutes for pages refresh).

As soon I have better understanding, I will send some screenshots with ideas of UI for some feedback.

bluszcz commented 2 years ago

To be honest, I am struggling with Vue Nextcloud components.

I was planning to do in place editing (like for categories), but for tags in Breadcrums, and then during few tries I understood this comment: but the component cannot display just one input element on the breadcrumbs bar.

So there is no really way to do the input element in the breadcrumbs bar?

seyfeb commented 2 years ago

To be honest, I never tried this. As a workaround, you could also show a dialog window for renaming the category? Or show a menu, when clicking on the breadcrumb name that allows renaming? Do you know about the Nextcloud Vue components documentation?

bluszcz commented 2 years ago

Thanks for head up. I am studying various options.

Do you know about the Nextcloud Vue components documentation?

Yes.

christianlupus commented 2 years ago

Just my 50ct: I was planning to replace the message boxes (alert and confirm) by modal dialogs (#842). Just to avoid duplicate work.

bluszcz commented 2 years ago

I tried modal inside same div after all breadcrumbs:

image

but it does not really work:

image

@seyfeb did you have any particular component in mind, when mentioning a "dialog window"?

seyfeb commented 2 years ago

Not in particular, but maybe it’s possible to show either a modal (might be a little to much "in ya face") or a popover, maybe in concert with an Action?

bluszcz commented 2 years ago

So I came up with some very temporary layout for now, it just handles properly submit:

image

and working now on the routes/controller/database part, php, learning the backend.