search

nextcloud / dashboard

ARCHIVED, new Dashboard is in the server
https://nextcloud.com/dashboard
GNU Affero General Public License v3.0
58 stars 29 forks source link

Dashboard should not call code of the activity app #3

Open nickvergessen opened 7 years ago

nickvergessen commented 7 years ago

https://github.com/nextcloud/dashboard/blob/master/lib/Service/ActivityService.php#L29-L31

This is wrong and should not be done. Apps must not call each others code like this. What you want to do is make it possible for other apps to provide dashboard panels. Have a look at:

  1. The activity manager with settings/filters/providers
  2. The notification manager with notifiers/apps
  3. The settings manager with personal/admin sections/settings

We have enough examples how to avoid inter-app-dependencies, but this here is just bad...