Open earendil1 opened 1 year ago
Can you share a screenshot of the notification? There are different emails being sent from different parts and I want to make sure it's the one from this app
Hi @nickvergessen thanks! Sure: here is the screenshot. I hope it is what you're looking for:
Okay, that is from the activity email: https://github.com/nextcloud/deck/blob/5669bd73cc6d735984c1afac1ab189f21bbfc082/lib/Activity/ActivityManager.php#L239
Might be caused by this bug then: https://github.com/nextcloud/deck/issues/4303
Moving to deck nevertheless so they can filter out if above issue solves it or not.
I hope I'm not hijacking this issue but I have one small addition: maybe it would even make sense to be able to restrict notifications to all cards assigned to me or being assigned to me. I have a Nextcloud instance here that makes heavy use of Deck boards and because many boards are shared with me, I get bombarded with notifications that are irrelevant to me. I didn't find an issue specific to that request - should I rather open a new one? Thanks!
Own comments notifications are sent because of this author override: https://github.com/nextcloud/deck/blob/1901c986fff8f8ff64253544eb1b1293fac46370/lib/Activity/ActivityManager.php#L435-L440
which breaks this check here: https://github.com/nextcloud/activity/blob/8cb1ca1bb9c1d32f2f447d46f0014c7bc44c4d20/lib/NotificationGenerator.php#L56-L57
it also causes wrong value for $ownActivity
to be set here:
https://github.com/nextcloud/deck/blob/1901c986fff8f8ff64253544eb1b1293fac46370/lib/Activity/DeckProvider.php#L89
The // Get rid of this once the frontend fetches comments/activity individually
comment is about 4 years old according to git blame so may be it is time to Get rid of the author override ?
Operating system: Linux 5.4.0-124-generic nextcloud/notifications#140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64
Web server: Hetzner Storage share
Database: nginx/1.18.0 (fpm-fcgi)
PHP version: 8.0.25
Nextcloud version: (see Nextcloud admin page) 24.0.7
Where did you install Nextcloud from: Hetzner Storage share
Signing status:
List of activated apps:
Nextcloud configuration:
Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...
Client configuration
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36
Operating system: Mac mini m1 Monterey
Logs
Nextcloud log (data/nextcloud.log)
Browser log