nextcloud / deck

🗂 Kanban-style project & personal management tool for Nextcloud, similar to Trello
https://apps.nextcloud.com/apps/deck
GNU Affero General Public License v3.0
1.21k stars 274 forks source link

Broken link in description after the attachment is deleted #518

Open cloud2018 opened 6 years ago

cloud2018 commented 6 years ago

Describe the bug In the description of a card the link of an inserted attachment is broken, after the attachment is deleted

To Reproduce

  1. Attach a file to a card
  2. Insert the attachment (test_attachment.txt) into description
  3. Delete the attachment
  4. Wait until the attachment is finally deleted and the icon for undelete is disappeared
  5. Open the card and click on the link "???? test_attachment.txt", which refers to (/nextcloud/apps/deck/cards/188/attachment/42)
  6. The nextcloud errorpage "Internal Server Error; The server was unable to complete your request.; If this happens again, ..." is displayed

Expected behavior In the description is only the text "???? test_attachment.txt" or "???? missing attachment: test_attachment.txt" and no clickable link, which refers to the deleted file

Tested with 0.4.0-beta3

Note Perhaps the behavior depends on the extension of the deleted file. With textfiles there is a broken link, with images it is just like expected "???? test_attachment.jpg" (without link)

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/60440834-broken-link-in-description-after-the-attachment-is-deleted?utm_campaign=plugin&utm_content=tracker%2F52758431&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F52758431&utm_medium=issues&utm_source=github).
juliushaertl commented 6 years ago

Seems to be a good improvement. But we need to take care we don't change the description but only show a hint about the missing attachment. Maybe a tooltip on the link would be a good option there.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.