Please use the 👍 reaction to show that you are affected by the same issue.
Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
Subscribe to receive notifications on status change and new comments.
Is your feature request related to a problem? Please describe.
Cards in dark theme are just like light theme but the colours inverted and it looks pretty bad. I fixed this problem in a fork of the repo but your contributing guidelines require me to sign off with my own real name which I refuse.
Describe the solution you'd like
In my fork I set the background to be distinctly separated from the background and disabling the box-shadow completely since it's looks stupid in dark mode. This change may seem counteractive and weird since now the light theme and dark theme doesn't work the same but this is literally how most websites make use of dark theme nowadays (e.g. Google, Discord). This is because our eyes doesn't see light colours the same as dark colours and makes dark colours harder to differentiate between for the human brain.
Describe alternatives you've considered
Well, none, but please if you do have a better option please share it with me.
Additional context
My fork of the proposed change that I did not want to pull request: https://github.com/ludverse/deck
much nicer:
Jerome-Herbinet
commented
6 months ago
How to use GitHub
Is your feature request related to a problem? Please describe. Cards in dark theme are just like light theme but the colours inverted and it looks pretty bad. I fixed this problem in a fork of the repo but your contributing guidelines require me to sign off with my own real name which I refuse.
Describe the solution you'd like In my fork I set the background to be distinctly separated from the background and disabling the box-shadow completely since it's looks stupid in dark mode. This change may seem counteractive and weird since now the light theme and dark theme doesn't work the same but this is literally how most websites make use of dark theme nowadays (e.g. Google, Discord). This is because our eyes doesn't see light colours the same as dark colours and makes dark colours harder to differentiate between for the human brain.
Describe alternatives you've considered Well, none, but please if you do have a better option please share it with me.
Additional context My fork of the proposed change that I did not want to pull request: https://github.com/ludverse/deck much nicer: