search

nextcloud / desktop

💻 Desktop sync client for Nextcloud
https://nextcloud.com/install/#install-clients
GNU General Public License v2.0
3.06k stars 803 forks source link

"Checking for changes" doesn't properly excluded unchecked directory #1112

Open GieltjE opened 5 years ago

GieltjE commented 5 years ago

Expected behaviour

Excluded directories should be skipped entirely during checking for changes

Actual behaviour

It hangs on the deselected directory for quite some time

Steps to reproduce

  1. Exclude a directory by dechecking it
  2. Fill the directory with thousands of tiny files
  3. Force a sync

Client configuration

Client version: 2.5.1final build 20171204 Operating system: Windows 10 1809 X64 OS language: English Installation path of client: Default

Server configuration

Operating system: Gentoo Web server: Apache 2.4.38 Database: Mariadb 10.3.12 PHP version: 7.3.2 Nextcloud version: 15.0.4 Storage backend (external storage): local disk

Logs

Camera/video/BYTEN/thumbs <-- has been unchecked in the UI, but still runs for every file....


[_csync_detect_update   file: Camera/video/BYTEN/thumbs/1_2019-02-17_11-50-19_large.jpg, instruction: INSTRUCTION_NEW <<=
[_csync_detect_update   Checking for rename based on inode # 1072627
[_csync_detect_update   file: Camera/video/BYTEN/thumbs/1_2019-02-17_11-52-03.jpg, instruction: INSTRUCTION_NEW <<=
[_csync_detect_update   Checking for rename based on inode # 1071945
[_csync_detect_update   file: Camera/video/BYTEN/thumbs/1_2019-02-17_11-52-03_large.jpg, instruction: INSTRUCTION_NEW <<=
[_csync_detect_update   Checking for rename based on inode # 1073335
[_csync_detect_update   file: Camera/video/BYTEN/thumbs/1_2019-02-17_11-52-36.jpg, instruction: INSTRUCTION_NEW <<=
[_csync_detect_update   Checking for rename based on inode # 1072630
[_csync_detect_update   file: Camera/video/BYTEN/thumbs/1_2019-02-17_11-52-36_large.jpg, instruction: INSTRUCTION_NEW <<=
[_csync_detect_update   Checking for rename based on inode # 1073601
[_csync_detect_update   file: Camera/video/BYTEN/thumbs/1_2019-02-17_11-53-26.jpg, instruction: INSTRUCTION_NEW <<=
[_csync_detect_update   Checking for rename based on inode # 1073346
[_csync_detect_update   file: Camera/video/BYTEN/thumbs/1_2019-02-17_11-53-26_large.jpg, instruction: INSTRUCTION_NEW <<=
[_csync_detect_update   Checking for rename based on inode # 1073846
[_csync_detect_update   file: Camera/video/BYTEN/thumbs/1_2019-02-17_11-54-13.jpg, instruction: INSTRUCTION_NEW <<=
[_csync_detect_update   Checking for rename based on inode # 1073670
[_csync_detect_update   file: Camera/video/BYTEN/thumbs/1_2019-02-17_11-54-13_large.jpg, ```
Terrox commented 5 years ago

I also have this issue. I have the directories in Global Ignored list but I keep seeing sub-directories being scanned that are within those directories. I am usually trying to ignore Unity3D Data, Obj & Library and .svn directories because they are not wanted on the server.

ghost commented 4 years ago

I did run into this is now as well when adding my desktop to sync only a folder with some text files (10MB) to my nextcloud server. And the nextcloud client scanned forever my complete Steam folders (at some point the client even crashed) :-(

Nextcloud client 2.6.4 on Arch Linux