explorer is killed by the Nextcloud Client

nextcloud / desktop

💻 Desktop sync client for Nextcloud

https://nextcloud.com/install/#install-clients

GNU General Public License v2.0

3.05k stars 801 forks source link

explorer is killed by the Nextcloud Client #1393

Open Tauebenuss opened 5 years ago

Tauebenuss commented 5 years ago

Expected behaviour

Don't break the explorer.exe

Actual behaviour

explorer.exe are not responding. after restart the explorer.exe everything works fine, expectly the synced nextcloud folders

Steps to reproduce

disconnect internet
edit some files local
sync this files
try to rename a file or open the context menu
explorer fails with "not responding"

PS: Crosstest (w/o Nextcloud Client works)

Client configuration

Client version: clean reinstall, with only one folder are synced to c:/users/user/nextcloud

Operating system: Windows 10 1903 (up to date) OS language: German

Qt version used by client package (Linux only, see also Settings dialog): -/- Client package (From Nextcloud or distro) (Linux only): -/- Installation path of client:

Server configuration

Nextcloud version: 16.0.4

Storage backend (external storage): No.

Logs

No logs provided.

proteusoz commented 4 years ago

Seeing something similar on 2.6.2, but instead of crashing we see this behavior.

If you have NextCloud running, just clicking the Microsoft's default 'File Explorer' icon on your Windows 1- taskbar results in nothing.

Stop NextClould client, and clicking on File Explorer icon works as it should.

Pingger commented 3 years ago

Can confirm this still being an issue with Nextcloud Server 21.0.1 and Nextcloud Desktop 3.1.3

I narrowed it down to the overlay icons (those small green checkmarks on files and folders). Windows requests those during rendering of the Explorer View causing it to lag, because Nextcloud Desktop often takes ages to provide the Icon for a single file. The Explorer also requests those serially ... so it waits for the first icon to complete until requesting the second icon. With Folders that contains MANY files, this can take up to several hours for the folder to be displayed and during this time halting each and every explorer.exe-Process on the system. So basically DDoSing a Nextcloud Server to High Latency, but not timeout, will actually DDoS the Windows System of every User using Nextcloud Desktop

Pingger commented 3 years ago

Just FYI: You can circumvent the issues by deleting the corresponding DLL and rebooting Windows. The DLL to delete/move to a different folder is: \<Nextcloud>/shellext/NCOverlays.dll

When this DLL can't be loaded, the Performance issues are gone(, but so are the overlay icons).

ChrisAichinger commented 3 years ago

I'm affected by this as well. Explorer is pretty much unusable within the Nextcloud folder while the Nextcloud Windows client is syncing in the background.

aardvarkl commented 2 years ago

I have just come across this. Is it still a bug after 2 years?

ThatCoffeeGuy commented 2 years ago

I have just come across this. Is it still a bug after 2 years?

Yes it is. Pretty sad.

NeurohrByteS commented 2 years ago

@Pingger Thank you for testing the workaround with the DLLs. The buggy integration crashed my system so regularly that on my checklist before having an online meeting "taskkill nextcloud.exe" was on the todo list and finally I had the time to find a solution.

I really would be fine with just disabling the integration btw. I have a complex setup (multiple users, shares to raids not directly connected to the server hosting nextcloud, all files are on encrypted hard drives, etc.) and I'm fine when a function is not right for me. Just let me disable it please :-)

Reaomaol commented 1 year ago

I can confirm in December 2022, this bug appears to be still active on Nextcloud Desktop Client 3.6.2 on Windows 11 22621 and the DLL workaround from @Pingger is still valid.

fenntek commented 1 year ago

Can confirm too on February 2023. Bug still exists with Nextcloud 25.03 and Desktop Client different Versions. Is there some kind of fix going to happen? My users and I would like to keep getting the status and use sync. (Some have more data on the cloud than storage on their pc.) Why is this still a problem and can I do anything on the server side to improve this anyway? It seems like this is only happening till there is a lot more data on the server. 8TB+. Does that have to do anything with it?

webster8347 commented 1 year ago

November 2023 and it still kills the Explorer and the Sync App stops reacting - embarassing.

hodyroff commented 1 year ago

Just check out ownCloud, I am sure it works there.

deepwather commented 10 months ago

I had exactly the same problem, also when right-click on files the explorer.exe was freezing. As well, with my complete fresh installed Windows 11, as soon as I installed the Nextcloud-Client the problem was back. The solution, for me, was to deactivate the "explorer integration" from Nextcloud-Client. Found here: