nextcloud / desktop

💻 Desktop sync client for Nextcloud
https://nextcloud.com/install/#install-clients
GNU General Public License v2.0
3.05k stars 801 forks source link

Enabling e2e app breaks Nextcloud Desktop Client Version 2.6.5 (Ubuntu) #2287

Closed PriceChild closed 4 years ago

PriceChild commented 4 years ago

How to use GitHub

Steps to reproduce

  1. Enable End to End synchronisation app on Nextcloud Server
  2. Create an encrypted folder using mobile app.

Expected behaviour

Nextcloud client on desktop should continue synchronising.

Actual behaviour

Nextcloud client on desktop stops synchronising

Server configuration

Operating system: Ubuntu 20.04

Web server: Nginx

Database: Mysql

PHP version: 7.4

Nextcloud version: 19.0.1

Updated from an older Nextcloud/ownCloud or fresh install: 15'ish

Where did you install Nextcloud from: ?

Signing status:

Signing status ``` No errors have been found. ```

List of activated apps:

App list ``` - accessibility: 1.5.0 - activity: 2.12.0 - admin_audit: 1.9.0 - announcementcenter: 3.8.1 - apporder: 0.10.0 - calendar: 2.0.3 - cloud_federation_api: 1.2.0 - comments: 1.9.0 - contacts: 3.3.0 - contactsinteraction: 1.0.0 - dav: 1.15.0 - deck: 1.0.5 - federatedfilesharing: 1.9.0 - federation: 1.9.0 - files: 1.14.0 - files_accesscontrol: 1.9.0 - files_external: 1.10.0 - files_pdfviewer: 1.8.0 - files_rightclick: 0.16.0 - files_sharing: 1.11.0 - files_trashbin: 1.9.0 - files_versions: 1.12.0 - files_videoplayer: 1.8.0 - firstrunwizard: 2.8.0 - groupfolders: 7.0.0 - logreader: 2.4.0 - lookup_server_connector: 1.7.0 - mail: 1.4.1 - maps: 0.1.6 - nextcloud_announcements: 1.8.0 - notes: 3.6.1 - notifications: 2.7.0 - oauth2: 1.7.0 - password_policy: 1.9.1 - phonetrack: 0.6.4 - photos: 1.1.0 - privacy: 1.3.0 - provisioning_api: 1.9.0 - recommendations: 0.7.0 - richdocuments: 3.7.3 - serverinfo: 1.9.0 - settings: 1.1.0 - sharebymail: 1.9.0 - social: 0.3.1 - spreed: 9.0.3 - survey_client: 1.7.0 - tasks: 0.13.3 - text: 3.0.1 - theming: 1.10.0 - twofactor_backupcodes: 1.8.0 - twofactor_nextcloud_notification: 2.3.0 - twofactor_totp: 4.1.3 - twofactor_u2f: 5.1.0 - updatenotification: 1.9.0 - viewer: 1.3.0 - workflowengine: 2.1.0 Disabled: - encryption - end_to_end_encryption (1.5.2 when enabled) - richdocumentscode - support - systemtags - user_ldap ```

Nextcloud configuration:

Config report ``` { "system": { "apps_paths": [ { "path": "\/var\/www\/nextcloud\/apps", "url": "\/apps", "writable": true } ], "supportedDatabases": [ "mysql" ], "filelocking.enabled": true, "memcache.local": "\\OC\\Memcache\\APCu", "memcache.distributed": "\\OC\\Memcache\\Redis", "memcache.locking": "\\OC\\Memcache\\Redis", "redis": { "host": "***REMOVED SENSITIVE VALUE***", "port": 6379, "timeout": 0 }, "instanceid": "***REMOVED SENSITIVE VALUE***", "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "x.2ships.co.uk", "x.example.com", "example.com", "cloud.example.com", "cloud-admin.example.com", "nextcloud-test", "nextcloud-test-admin" ], "datadirectory": "***REMOVED SENSITIVE VALUE***", "overwrite.cli.url": "https:\/\/cloud.example.com", "dbtype": "mysql", "version": "19.0.1.1", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbport": "", "dbtableprefix": "oc_", "mysql.utf8mb4": true, "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "installed": true, "mail_smtpmode": "smtp", "mail_smtpauthtype": "LOGIN", "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_domain": "***REMOVED SENSITIVE VALUE***", "mail_smtpsecure": "ssl", "mail_smtpauth": 1, "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpport": "465", "mail_smtpname": "***REMOVED SENSITIVE VALUE***", "mail_smtppassword": "***REMOVED SENSITIVE VALUE***", "loglevel": 0, "maintenance": false, "theme": "", "updater.release.channel": "stable", "trusted_proxies": "***REMOVED SENSITIVE VALUE***", "mail_sendmailmode": "smtp", "activity_expire_days": 365 } } ```

Are you using external storage, if yes which one: No

Are you using encryption: trying

Are you using an external user-backend, if yes which one: no

Client configuration

Browser: NA

Operating system: Ubuntu

Logs

Web server error log

Web server error log ``` Available on request ```

Nextcloud log (data/nextcloud.log)

Nextcloud log ``` 2020-08-19 10:58:56:291 [ info nextcloud.gui.application ]: "################## Nextcloud locale:[en_GB] ui_lang:[] version:[2.6.5-20200713.144448.adada8b2e-1.0~focal1] os:[Ubuntu 20.04.1 LTS]" 2020-08-19 10:58:56:291 [ info nextcloud.gui.application ]: Using "en_GB" translation 2020-08-19 10:58:56:291 [ info nextcloud.gui.socketapi ]: server started, listening at "/run/user/1000/Nextcloud/socket" 2020-08-19 10:58:56:291 [ info nextcloud.gui.folder.manager ]: setting remote poll timer interval to 30000 msec 2020-08-19 10:58:56:307 [ info nextcloud.gui.account.manager ]: Account for QUrl("https://x.example.com") using auth type "webflow" 2020-08-19 10:58:56:307 [ info nextcloud.sync.credentials.webflow ]: Get QNAM 2020-08-19 10:58:56:332 [ warning nextcloud.sync.credentials.keychainchunk ]: Unable to read "proxy-password" chunk "0" "Entry not found" 2020-08-19 10:58:56:347 [ info nextcloud.gui.application ]: Tray menu workarounds: noabouttoshow: false fakedoubleclick: false showhide: false manualvisibility: false 2020-08-19 10:58:56:347 [ info nextcloud.sync.accessmanager ]: 6 "GET" "https://x.example.com/ocs/v2.php/core/navigation/apps?absolute=true&format=json" has X-Request-ID "44cbe65c-c4f7-4791-9033-1562470177a4" 2020-08-19 10:58:56:347 [ info nextcloud.sync.networkjob ]: OCC::OcsNavigationAppsJob created for "https://x.example.com" + "ocs/v2.php/core/navigation/apps" "" 2020-08-19 10:58:56:348 [ info nextcloud.gui.folder.manager ]: Setup folders from settings file 2020-08-19 10:58:56:348 [ info nextcloud.sync.configfile ]: Adding user defined ignore list to csync: "/home/pricey/.config/Nextcloud/sync-exclude.lst" 2020-08-19 10:58:56:350 [ info nextcloud.gui.folder.manager ]: Adding folder to Folder Map OCC::Folder(0x564136c61690) "1" 2020-08-19 10:58:56:383 [ info nextcloud.gui.folder.manager ]: Schedule folder "1" to sync! 2020-08-19 10:58:56:383 [ info nextcloud.gui.folder.manager ]: Folder is not ready to sync, not scheduled! 2020-08-19 10:58:56:384 [ info nextcloud.gui.application ]: Sync state changed for folder "https://x.example.com/remote.php/webdav/" : "Not yet Started" 2020-08-19 10:58:56:391 [ info nextcloud.sync.database ]: sqlite3 version "3.31.1" 2020-08-19 10:58:56:391 [ info nextcloud.sync.database ]: sqlite3 journal_mode= "wal" 2020-08-19 10:58:56:392 [ info nextcloud.sync.clientproxy ]: Set proxy configuration to use the preferred system proxy for http tcp connections 2020-08-19 10:58:56:401 [ info nextcloud.sync.credentials.webflow ]: Fetch from keychain! 2020-08-19 10:58:56:403 [ warning nextcloud.sync.credentials.keychainchunk ]: Unable to read "pricey_clientCertificatePEM:https://x.example.com/:0" chunk "0" "Entry not found" 2020-08-19 10:58:56:404 [ warning nextcloud.sync.credentials.keychainchunk ]: Unable to read "pricey_clientKeyPEM:https://x.example.com/:0" chunk "0" "Entry not found" 2020-08-19 10:58:56:404 [ warning nextcloud.sync.credentials.webflow ]: Unable to read client key "Entry not found" 2020-08-19 10:58:56:405 [ warning nextcloud.sync.credentials.keychainchunk ]: Unable to read "pricey_clientCaCertificatePEM0:https://x.example.com/:0" chunk "0" "Entry not found" 2020-08-19 10:58:56:405 [ warning nextcloud.sync.credentials.webflow ]: Unable to read client CA cert slot "0" "Entry not found" 2020-08-19 10:58:56:406 [ info nextcloud.gui.account.state ]: Fetched credentials for "https://x.example.com" attempting to connect 2020-08-19 10:58:56:406 [ info nextcloud.sync.credentials.webflow ]: Get QNAM 2020-08-19 10:58:56:406 [ info nextcloud.sync.connectionvalidator ]: No system proxy set by OS 2020-08-19 10:58:56:406 [ info nextcloud.sync.accessmanager ]: 2 "" "https://x.example.com/status.php" has X-Request-ID "a9e64e3e-2f93-41c1-b2b2-a806c7b5754d" 2020-08-19 10:58:56:406 [ info nextcloud.sync.networkjob ]: OCC::CheckServerJob created for "https://x.example.com" + "status.php" "OCC::ConnectionValidator" 2020-08-19 10:58:56:407 [ info nextcloud.sync.accessmanager ]: 6 "GET" "https://x.example.com/ocs/v2.php/core/navigation/apps?absolute=true&format=json" has X-Request-ID "50adffb3-f559-4325-bac4-a5b7103c2984" 2020-08-19 10:58:56:407 [ info nextcloud.sync.networkjob ]: OCC::OcsNavigationAppsJob created for "https://x.example.com" + "ocs/v2.php/core/navigation/apps" "" 2020-08-19 10:58:56:693 [ info nextcloud.sync.credentials.webflow ]: request finished 2020-08-19 10:58:56:693 [ info nextcloud.sync.networkjob.checkserver ]: status.php returns: QJsonDocument({"edition":"","extendedSupport":false,"installed":true,"maintenance":false,"needsDbUpgrade":false,"productname":"Nextcloud","version":"19.0.1.1","versionstring":"19.0.1"}) QNetworkReply::NoError Reply: QNetworkReplyHttpImpl(0x564136cb95f0) 2020-08-19 10:58:56:693 [ info nextcloud.sync.connectionvalidator ]: ** Application: ownCloud found: QUrl("https://x.example.com") with version "19.0.1" ( "19.0.1.1" ) 2020-08-19 10:58:56:693 [ info nextcloud.sync.connectionvalidator ]: QUrl("https://x.example.com") has server version "19.0.1.1" 2020-08-19 10:58:56:694 [ info nextcloud.sync.accessmanager ]: 6 "PROPFIND" "https://x.example.com/remote.php/webdav/" has X-Request-ID "c45396bf-3c60-4d64-be6c-0577e253e756" 2020-08-19 10:58:56:694 [ info nextcloud.sync.networkjob ]: OCC::PropfindJob created for "https://x.example.com" + "/" "OCC::ConnectionValidator" 2020-08-19 10:58:56:731 [ info nextcloud.sync.account ]: appPassword stored in keychain 2020-08-19 10:58:57:186 [ info nextcloud.sync.credentials.webflow ]: request finished 2020-08-19 10:58:58:380 [ info nextcloud.sync.credentials.webflow ]: request finished 2020-08-19 10:58:58:380 [ info nextcloud.sync.networkjob.propfind ]: PROPFIND of QUrl("https://x.example.com/remote.php/webdav/") FINISHED WITH STATUS "OK" 2020-08-19 10:58:58:380 [ info nextcloud.sync.accessmanager ]: 2 "" "https://x.example.com/ocs/v1.php/cloud/capabilities?format=json" has X-Request-ID "6c4c243b-c0af-4a0e-86c3-3d0a6430e60b" 2020-08-19 10:58:58:381 [ info nextcloud.sync.networkjob ]: OCC::JsonApiJob created for "https://x.example.com" + "ocs/v1.php/cloud/capabilities" "OCC::ConnectionValidator" 2020-08-19 10:58:58:381 [ info nextcloud.sync.accessmanager ]: 2 "" "https://x.example.com/ocs/v1.php/config?format=json" has X-Request-ID "14cb6b41-f120-4942-abf0-00f4ee79df30" 2020-08-19 10:58:58:382 [ info nextcloud.sync.networkjob ]: OCC::JsonApiJob created for "https://x.example.com" + "ocs/v1.php/config" "" 2020-08-19 10:58:59:092 [ info nextcloud.sync.credentials.webflow ]: request finished 2020-08-19 10:58:59:092 [ info nextcloud.sync.networkjob.jsonapi ]: JsonApiJob of QUrl("https://x.example.com/ocs/v1.php/config?format=json") FINISHED WITH STATUS "OK" 2020-08-19 10:58:59:093 [ info nextcloud.sync.connectionvalidator ]: Determined user-visible host to be "x.example.com" 2020-08-19 10:58:59:495 [ info nextcloud.sync.credentials.webflow ]: request finished 2020-08-19 10:58:59:495 [ info nextcloud.sync.networkjob.jsonapi ]: JsonApiJob of QUrl("https://x.example.com/ocs/v1.php/cloud/capabilities?format=json") FINISHED WITH STATUS "OK" 2020-08-19 10:58:59:496 [ info nextcloud.sync.connectionvalidator ]: Server capabilities QJsonObject({"activity":{"apiv2":["filters","filters-api","previews","rich-strings"]},"bruteforce":{"delay":0},"core":{"pollinterval":60,"webdav-root":"remote.php/webdav"},"dav":{"chunking":"1.0"},"deck":{"version":"1.0.5"},"end-to-end-encryption":{"api-version":"1.1","enabled":true},"files":{"bigfilechunking":true,"blacklisted_files":[".htaccess"],"directEditing":{"etag":"6226ba873373f5e73a3ef504107523f7","url":"https://x.example.com/ocs/v2.php/apps/files/api/v1/directEditing"},"undelete":true,"versioning":true},"files_sharing":{"api_enabled":true,"default_permissions":17,"federation":{"expire_date":{"enabled":true},"incoming":true,"outgoing":true},"group":{"enabled":true,"expire_date":{"enabled":true}},"group_sharing":true,"public":{"enabled":true,"expire_date":{"enabled":false},"expire_date_internal":{"enabled":false},"multiple_links":true,"password":{"askForOptionalPassword":false,"enforced":false},"send_mail":false,"upload":true,"upload_files_drop":true},"resharing":true,"sharebymail":{"enabled":true,"expire_date":{"enabled":true},"password":{"enabled":true},"upload_files_drop":{"enabled":true}},"sharee":{"query_lookup_default":false},"user":{"expire_date":{"enabled":true},"send_mail":false}},"notes":{"api_version":["0.2","1.1"],"version":"3.6.1"},"notifications":{"admin-notifications":["ocs","cli"],"ocs-endpoints":["list","get","delete","delete-all","icons","rich-strings","action-web"],"push":["devices","object-data","delete"]},"ocm":{"apiVersion":"1.0-proposal1","enabled":true,"endPoint":"https://x.example.com/ocm","resourceTypes":[{"name":"file","protocols":{"webdav":"/public.php/webdav/"},"shareTypes":["user","group"]}]},"password_policy":{"api":{"generate":"https://x.example.com/ocs/v2.php/apps/password_policy/api/v1/generate","validate":"https://x.example.com/ocs/v2.php/apps/password_policy/api/v1/validate"},"enforceNonCommonPassword":true,"enforceNumericCharacters":false,"enforceSpecialCharacters":false,"enforceUpperLowerCase":false,"minLength":8},"richdocuments":{"collabora":{"convert-to":{"available":false},"hasMobileSupport":true,"hasTemplateSaveAs":false,"hasTemplateSource":true,"productName":"Collabora Online Development Edition"},"config":{"disable_certificate_verification":"","doc_format":"odf","edit_groups":null,"public_wopi_url":"https://loo.example.com","use_groups":"","wopi_url":"https://loo.example.com"},"direct_editing":true,"mimetypes":["application/vnd.oasis.opendocument.text","application/vnd.oasis.opendocument.spreadsheet","application/vnd.oasis.opendocument.graphics","application/vnd.oasis.opendocument.presentation","application/vnd.lotus-wordpro","application/vnd.visio","application/vnd.wordperfect","application/msonenote","application/msword","application/rtf","text/rtf","application/vnd.openxmlformats-officedocument.wordprocessingml.document","application/vnd.openxmlformats-officedocument.wordprocessingml.template","application/vnd.ms-word.document.macroEnabled.12","application/vnd.ms-word.template.macroEnabled.12","application/vnd.ms-excel","application/vnd.openxmlformats-officedocument.spreadsheetml.sheet","application/vnd.openxmlformats-officedocument.spreadsheetml.template","application/vnd.ms-excel.sheet.macroEnabled.12","application/vnd.ms-excel.template.macroEnabled.12","application/vnd.ms-excel.addin.macroEnabled.12","application/vnd.ms-excel.sheet.binary.macroEnabled.12","application/vnd.ms-powerpoint","application/vnd.openxmlformats-officedocument.presentationml.presentation","application/vnd.openxmlformats-officedocument.presentationml.template","application/vnd.openxmlformats-officedocument.presentationml.slideshow","application/vnd.ms-powerpoint.addin.macroEnabled.12","application/vnd.ms-powerpoint.presentation.macroEnabled.12","application/vnd.ms-powerpoint.template.macroEnabled.12","application/vnd.ms-powerpoint.slideshow.macroEnabled.12","text/csv"],"mimetypesNoDefaultOpen":["image/svg+xml","application/pdf","text/plain","text/spreadsheet"],"productName":"Collabora Online Development Edition","templates":true},"spreed":{"config":{"attachments":{"allowed":true,"folder":"/Talk"},"chat":{"max-length":32000},"conversations":{"can-create":true}},"features":["audio","video","chat-v2","conversation-v2","guest-signaling","empty-group-room","guest-display-names","multi-room-users","favorites","last-room-activity","no-ping","system-messages","mention-flag","in-call-flags","notification-levels","invite-groups-and-mails","locked-one-to-one-rooms","read-only-rooms","chat-read-marker","webinary-lobby","start-call-flag","chat-replies","circles-support","force-mute","chat-reference-id"]},"theming":{"background":"https://x.example.com/core/img/background.png?v=24","background-default":true,"background-plain":false,"color":"#0082c9","color-element":"#0082c9","color-element-bright":"#0082c9","color-element-dark":"#0082c9","color-text":"#ffffff","favicon":"https://x.example.com/core/img/logo/logo.svg?v=24","logo":"https://x.example.com/core/img/logo/logo.svg?v=24","logoheader":"https://x.example.com/core/img/logo/logo.svg?v=24","name":"Nextcloud","slogan":"a safe home for all your data","url":"https://cloud.example.com"}}) 2020-08-19 10:58:59:497 [ info nextcloud.sync.accessmanager ]: 2 "" "https://x.example.com/ocs/v1.php/cloud/user?format=json" has X-Request-ID "c53ae7d9-04a9-4e9b-b40b-ab12a0da08e8" 2020-08-19 10:58:59:497 [ info nextcloud.sync.networkjob ]: OCC::JsonApiJob created for "https://x.example.com" + "ocs/v1.php/cloud/user" "OCC::UserInfo" 2020-08-19 10:58:59:620 [ info nextcloud.sync.credentials.webflow ]: request finished 2020-08-19 10:58:59:620 [ info nextcloud.sync.networkjob.jsonapi ]: JsonApiJob of QUrl("https://x.example.com/ocs/v1.php/cloud/user?format=json") FINISHED WITH STATUS "OK" 2020-08-19 10:58:59:621 [ info nextcloud.sync.accessmanager ]: 2 "" "https://x.example.com/remote.php/dav/avatars/pricey/128.png" has X-Request-ID "1e766d99-9f98-4be4-b7b5-077c30586107" 2020-08-19 10:58:59:622 [ info nextcloud.sync.networkjob ]: OCC::AvatarJob created for "https://x.example.com" + "" "OCC::UserInfo" 2020-08-19 10:58:59:813 [ info nextcloud.sync.credentials.webflow ]: request finished 2020-08-19 10:58:59:818 [ info nextcloud.sync.clientsideencryption ]: Initializing 2020-08-19 10:58:59:823 [ info nextcloud.sync.clientsideencryption ]: Retrieving public key from server 2020-08-19 10:58:59:823 [ info nextcloud.sync.accessmanager ]: 2 "" "https://x.example.com/ocs/v2.php/apps/end_to_end_encryption/api/v1/public-key?format=json" has X-Request-ID "f7a28985-33d2-4791-8a37-1c3c668718db" 2020-08-19 10:58:59:824 [ info nextcloud.sync.networkjob ]: OCC::JsonApiJob created for "https://x.example.com" + "ocs/v2.php/apps/end_to_end_encryption/api/v1/public-key" "OCC::ClientSideEncryption" 2020-08-19 10:58:59:930 [ info nextcloud.sync.credentials.webflow ]: request finished 2020-08-19 10:58:59:930 [ warning nextcloud.sync.networkjob ]: QNetworkReply::ContentAccessDenied "Server replied \"403 Forbidden\" to \"GET https://x.example.com/ocs/v2.php/apps/end_to_end_encryption/api/v1/public-key?format=json\"" QVariant(int, 403) 2020-08-19 10:58:59:930 [ warning nextcloud.sync.credentials.webflow ]: QNetworkReply::ContentAccessDenied 2020-08-19 10:58:59:930 [ warning nextcloud.sync.credentials.webflow ]: "Error transferring https://x.example.com/ocs/v2.php/apps/end_to_end_encryption/api/v1/public-key?format=json - server replied: Forbidden" 2020-08-19 10:58:59:930 [ info nextcloud.sync.networkjob.jsonapi ]: JsonApiJob of QUrl("https://x.example.com/ocs/v2.php/apps/end_to_end_encryption/api/v1/public-key?format=json") FINISHED WITH STATUS "ContentAccessDenied Server replied \"403 Forbidden\" to \"GET https://x.example.com/ocs/v2.php/apps/end_to_end_encryption/api/v1/public-key?format=json\"" 2020-08-19 10:58:59:930 [ warning nextcloud.sync.networkjob.jsonapi ]: Network error: "ocs/v2.php/apps/end_to_end_encryption/api/v1/public-key" "Server replied \"403 Forbidden\" to \"GET https://x.example.com/ocs/v2.php/apps/end_to_end_encryption/api/v1/public-key?format=json\"" QVariant(int, 403) 2020-08-19 10:58:59:930 [ info nextcloud.sync.clientsideencryption ]: Error while requesting public key: 403 2020-08-19 10:59:28:624 [ warning nextcloud.gui.account.state ]: ConnectionValidator already running, ignoring "pricey@x.example.com" ```

Browser log

Browser log ``` NA ```
georgehrke commented 4 years ago

Version 1.5.2 of the end_to_end_encryption app only works with the Desktop Client version 3 and above.

georgehrke commented 4 years ago

I will move this to the desktop repo, so this issue can be triaged there.

georgehrke commented 4 years ago

I'm not sure if there are plans to release another version of the 2.6.x branch.

PriceChild commented 4 years ago

@georgehrke Thanks. I accept it needs the desktop client update to work, and will update once it's built in the PPA.

What's surprising is that enabling the app breaks all synchronisation by the desktop client. This becomes "desktop client <3 is incompatible with any server running end_to_end_encryption 1.5.2" which is a very different limitation than advertised.

er-vin commented 4 years ago

I'm not sure if there are plans to release another version of the 2.6.x branch.

Indeed no real plan for that.

er-vin commented 4 years ago

@georgehrke Thanks. I accept it needs the desktop client update to work, and will update once it's built in the PPA.

What's surprising is that enabling the app breaks all synchronisation by the desktop client. This becomes "desktop client <3 is incompatible with any server running end_to_end_encryption 1.5.2" which is a very different limitation than advertised.

Right, I guess it's because 2.6.5 didn't contain a check on the protocol version... So it tries to connect on e2ee protocol 1.1 but then gets stuck because it is rejected by the server with a bunch of 403 error. I'll look at how involved it'd be to fix 2.6 in that regard and maybe we'll roll out a 2.6.6 with this if that does the trick.

The potential PR will have an AppImage automatically produced, I'd appreciate it if you could test it and report on the PR when that shows up.

PriceChild commented 4 years ago

I'm not sure of the value of rolling out a 2.6.6 - the issue is moot for anyone who updates to 3.0.0?

If someone isn't able to update to 3.0.0 then their reasons will likely also hamper upgrades to 2.6.6.

er-vin commented 4 years ago

I'm not sure of the value of rolling out a 2.6.6 - the issue is moot for anyone who updates to 3.0.0?

Yes it is.

If someone isn't able to update to 3.0.0 then their reasons will likely also hamper upgrades to 2.6.6.

Which is a good point, you're kind of pushing me to close this one right away though. ;-)

PriceChild commented 4 years ago

@er-vin I wouldn't be opposed to that. I hope it may now be quicker for someone find this issue and understand the problem without having to set up logging in their client to get what I pasted above. (Which took me more time than I'd care to admit)

Originally I wondered whether end_to_end_encryption had a responsibility to make it clearer somehow when you install the app that you do need a minimum client version, perhaps in their README if not the app install screen? But even then, there's going to be little value in that in a few days once client updates have rolled out.

PriceChild commented 4 years ago

Whoops, misclick, I'll let you decide whether to close.

My other consideration is that output like https://nextcloud.com/endtoend/ makes it clearer this project is now ready/production.

There is a warning on the app store:

Provides the necessary endpoint to enable end-to-end encryption. End-to-end encryption is still in alpha state, don't use this in production and only with test data!

But I'm assuming that'll now go away. It doesn't matter to me, or I'm sure most home users, but I imagine larger deployments might appreciate a clearer warning from end_to_end_encryption somewhere (Not sure of the best place) about the minimum version deployment?

georgehrke commented 4 years ago

But I'm assuming that'll now go away.

Yes, i forgot to update that. Will take care of that.

er-vin commented 4 years ago

Alright, so after investigation checking on the API version makes things somewhat worse (at least not better) it goes further in the sync but then create situations where it fails uploading anyway because it didn't lock some folder... so let's not change 2.6.

@georgehrke I thus let you close this one once the doc update is done on your end. Thanks in advance.

csware commented 4 years ago

Maybe old Nextcloud clients can be blocked in the E2E server app.,

er-vin commented 4 years ago

Maybe old Nextcloud clients can be blocked in the E2E server app.,

Already the case, but the nature of how the syncing happened in 2.6 clients it will still try to upload and fail. Nothing can be done about that unfortunately.

georgehrke commented 4 years ago

@georgehrke I thus let you close this one once the doc update is done on your end. Thanks in advance.

Added the minimum versions to the release page: https://github.com/nextcloud/end_to_end_encryption/releases and removed the unstable info: https://github.com/nextcloud/end_to_end_encryption/pull/188 (needs a new release to be shown on the appstore)