search

nextcloud / desktop

đź’» Desktop sync client for Nextcloud
https://nextcloud.com/install/#install-clients
GNU General Public License v2.0
3.05k stars 800 forks source link

upgrade to 3.1.3 crashed windows-explorer and firefox #3131

Open r2evans opened 3 years ago

r2evans commented 3 years ago

Expected behaviour

A version update closes just Nextcloud, performs the update, and restarts it.

Actual behaviour

As soon as I hit the UAC "yes", Windows' explorer.exe (not IExplore) crashed, Firefox was killed. Everything paused until Nextcloud update was good and happy, then things started coming back.

Client configuration

Client version: from 3.1.2 to 3.1.3

Operating system: win10_64

OS language: english

Installation path of client: (standard)

Logs

(I recognize you really need the logs. However, there's too much info leakage in the debug archive that I will not post to a github issue. Perhaps somebody with less data-paranoia (aka, company infosec policy) will be able to augment this with something from their update.)

FlexW commented 3 years ago

Could you please explain what UAC means? Closing the explorer is necessary because of the shell integration.

r2evans commented 3 years ago

(UAC is "User Access Control", see https://docs.microsoft.com/en-us/windows/security/identity-protection/user-account-control/how-user-account-control-works. It's the windows OS asking the user to do a task that requires elevated permissions.)

Githopp192 commented 3 years ago

had a similar behave today.

Environment: Windows 10 20H2, NC Agent Upgrade v.3.2.1

Gm-O commented 3 years ago

I have just experienced a similar behaviour today under Windows 10 which I want to share with you.

Expected behaviour

A version update closes just the Nextcloud client, performs the update, and restarts it. Other processes are not affected.

Actual behaviour

What is really bothering me is that all Explorer and Firefox processes were terminated without prior notice, hence giving me no chance to save any changes I had made.

Client configuration

Client version:

Operating system: win10_64

OS language: German

Installation path of client: (standard)

r2evans commented 3 years ago

I recognize that due to the integration with Explorer, it needs a restart. I suggest that this should be an explicit notification step, perhaps

  1. UAC dialog
  2. Additional modal with "Because of integration with Windows Explorer, it needs to be restarted as well." This dialog should have "OK" and "Cancel", in case I really don't want explorer (and firefox!) to restart right now.

This doesn't resolve why firefox died as well, not sure if that's explicit or a side-effect of explorer restarting.

chk1 commented 3 years ago

I believe this is a forced restart of Explorer and Firefox, not a crash, since I don't get the "Firefox crashed" or session restore option. There are also several events in the Windows Event Viewer for "RestartManager" that relate to this, right around installation time.

image

Application or service "Firefox" is being shut down.

Regardless, this feels quite "intrusive" and annoying. I don't know how Nextcloud integrates into Firefox. Please let me chose wheter to restart or not.

Nextcloud 3.3.6 on Windows 10

Malspherus commented 3 years ago

Can confirm the same thing happens when upgrading the client to 3.3.6, I didn't get a crash dialogue from firefox either. Win10 64bit, Version 20H2. Had this problem with earlier updates as well, but unfortunately I don't remember at what version it started. In my case it also caused some tray icons to disappear, even though the related processes were still running and functional, in some cases even preventing me from starting them again without first killing them via the task manager.

Just restarting explorer and firefox without explicit decision by the user and potentially irreversibly closing folders and tabs is an absolute no-go in my eyes.

Githopp192 commented 3 years ago

can confirm, did the upgrade to Version 3.3.6 (Windows) one day ago:

exactly the same behave as of 2 of May '21

Environment: Windows 10 20H2, NC Agent Upgrade v.3.3.6 Automatic message from NC Agent appeared - Upgrading from v.3.3.5 to v.3.3.6 Clicked on the Upgrade Button Windows Explorer did stop (i'm not sure - due to the Nextcloud Agent Upgrade process or W10 explorer crash !?) Got a blank screen Did wait a couple of minutes no change - blank screen (no tasklist, no explorer windows, nothing) ctr-alt-delete to open task-manager run "new tasks" --> explorer explorer did start - but now explorer will run in a 'never-ending' start/stop Loop ctr-alt-delete to open task-manager run "cmd" to open command cli check for explorer processes --> tasklist | find "explorer" needed to kill the top explorer process on the list --> taskkill /F /PID now explorer is there again - nextcloud icon on the desktop & and the agent seems to work so far

nursoda commented 2 years ago

Apart from the Windows Explorer issue which seems to only happen on updating and thus must be handled by the Installer, I can 100% reliably reproduce that shutting down the NC desktop sync client on Arch Linux (using its notification icon→Close) does force-close my Firefox (opening Mozilla Crash Reporter). It also used to force-close Thunderbird once or twice but I cannot reproduce that reliably. Shall I open a new bug for that or is it likely the same root cause to be addressed here?

joshtrichards commented 2 months ago

I don't believe this issue is necessary anymore today. A lot of things have changed in the update process. What's your take these days, @r2evans?

r2evans commented 2 months ago

I just tried an upgrade, and Explorer was force-closed. Granted, it told me it wanted to do that first, but it is still a disruptive act that is not without side-effects. (And now it is telling me I must restart the computer, a long standing issue. These two things are really disruptive and frustrating.)

Good news, though, Firefox was open and not closed. Halfway there :-)