search

nextcloud / desktop

đź’» Desktop sync client for Nextcloud
https://nextcloud.com/install/#install-clients
GNU General Public License v2.0
3.07k stars 804 forks source link

Renaming folder deletes Readme.md within the folder #3320

Open whisperdancer opened 3 years ago

whisperdancer commented 3 years ago

How to use GitHub

Expected behaviour

Changing the name of a parent folder causes Readme.md file to be deleted. Create a parent folder in windows file explorer, then create Readme.md in web UI. Then change name of parent folder in windows file explorer and it deletes the Readme.md file.

Actual behaviour

Changing the name of parent folder in windows file explorer and expect the children files to not be deleted.

Steps to reproduce

  1. Create a folder in windows file explorer. Then create a sub folder.
  2. Go to nextcloud in web browser. Click top area to create a Readme.md file so now you have the Readme.md and the subfolder as children under the parent folder
  3. Go back to folder in windows file explorer and change the name of the parent folder.
  4. The virtual file system promptly deletes the Readme.md file

I then navigate to deleted files and I see the original parent folder before it was renamed with the original children including the Readme.md file.

However, the sub folder and it’s contents were not removed. It’s only removing the Readme.md file. It may be worse problem, but appears to be isolated to deleting the Readme.md file only. As least it's the only one I can verify is happening.

Client configuration

Client version: Windows Desktop 3.2.1

Operating system: Win 10 10.0.19042 Buid 19042

OS language:

Qt version used by client package (Linux only, see also Settings dialog):

Client package (From Nextcloud or distro) (Linux only):

Installation path of client:

Server configuration

NC 21.0.1 php 8.0 nginx

Logs

Please use Gist (https://gist.github.com/) or a similar code paster for longer logs.

  1. Client logfile: Since 3.1: Under the "General" settings, you can click on "Create Debug Archive ..." to pick the location of where the desktop client will export the logs and the database to a zip file. On previous releases: Via the command line: nextcloud --logdebug --logwindow or nextcloud --logdebug --logfile log.txt (See also https://docs.nextcloud.com/desktop/3.0/troubleshooting.html#log-files)

  2. Web server error log:

  3. Server logfile: nextcloud log (data/nextcloud.log):

whisperdancer commented 3 years ago

It just happened again this morning. I changed the name of the folder and it wiped the Readme.md file. When a folder is renamed it appears to be deleting the entire folder and it's child items, then not properly restoring the child items.

mgallien commented 3 years ago

I will be working on a fix.

I can reproduce this bug only with virtual sync folders. In the meantime, if you are impacted by this bug, you can temporarily switch to non virtual synchronization folder.

whisperdancer commented 3 years ago

I will be working on a fix.

I can reproduce this bug only with virtual sync folders. In the meantime, if you are impacted by this bug, you can temporarily switch to non virtual synchronization folder.

The non virtual sync folder has a different problem. When I change the folder name, it creates a new folder so I now have two folders, the one before the name change and the new one with the name change. I then have to manually delete the one without the name change. This happens on every folder name change from within windows file explorer.The

The difference between non virtual and virtual is with non virtual there is no data loss. The folder with the name change retains all the correct child items including Readme.md. The dup is the original folder and is deleting child items, but not important as this folder shouldn't be there after the change and must be manually deleted.

FunkMonkey commented 2 years ago

any update on this issue?

It just happend to me as well. I renamed a folder in Windows Explorer and the NextCloud Client of a colleague instantly deleted the files of that folder. There were also errors shown when restoring the files (even though they were restored properly).