nextcloud / desktop

💻 Desktop sync client for Nextcloud
https://nextcloud.com/install/#install-clients
GNU General Public License v2.0
2.99k stars 788 forks source link

Enhance sparkle updater for MacOS #4415

Open tobiasKaminsky opened 2 years ago

tobiasKaminsky commented 2 years ago

Currently our sparkle updater (which also support delta update recently) is on a very old version and not enabled.

claucambra commented 2 years ago

The biggest issue right now for us using Sparkle 2 is that there is practically no documentation on how to integrate it with applications not made through Xcode. Pretty tellingly all cross-platform projects I have come across still use the 1.X versions, e.g. VLC, Transmission, Hedgewars

We can at least initially support the latest 1.X version with our current code and ensure that works well and then figure out how (and if) we can update to 2.X

tobiasKaminsky commented 2 years ago

Totally fine, as long as 1.x works 👍

ya-d commented 1 year ago

Not sure if it works for me! Automatic updates are broken on my Apple Silicon M1 notebook. Is that because it is not supported by the Sparkle version the client uses?

I couldn’t figure which version you use. Sparkle 1.24+ seems to support Apple Silicon. Latest 1.x version seems to be 1.27.1. Although this release note states that "Sparkle supports Apple Silicon (ARM) if you compile it yourself using the latest Xcode beta.".

Thanks for looking into making this ready for Arm-Macs!

image
claucambra commented 1 year ago

We are using Sparkle 1.27 and this definitely works with M1 Macs, it is the only way I update the client on my own machine

If you are running a version of the client that was originally installed before the updater was integrated this might be the issue -- could you try closing the application, deleting it, and reinstalling it?

ya-d commented 1 year ago

Thanks for the reply. I just did that and am on the latest version now. Guess I have to wait for the next update and see if it works. Otherwise I will delete it again and get rid of all related files as well. I just deleted the .app image for now to not loose my config. Thanks again, I will get back if the issue persists.

unikitty37 commented 1 year ago

Would it be possible to add "show the changelog in the Sparkle dialog" to the list?

Other apps show what's new — see the attached image — but Nextcloud doesn't. That means you either upgrade blind, or open a browser and try to find the changelog. It would be much better if it could appear in the update dialog.

image

I'm fairly sure Sparkle 1 supports it, as apps have been doing this for ages, but I'm not sure what's involved in getting Nextcloud to support it 😁

joshtrichards commented 1 month ago

@unikitty37 Reasonable idea, but please create a dedicated enhancement tracking issue for it. Thanks!