nextcloud / desktop

💻 Desktop sync client for Nextcloud
https://nextcloud.com/install/#install-clients
GNU General Public License v2.0
3.05k stars 801 forks source link

[Bug]: Moving E2EE files while they are being sync'd leads to file locking errors #4498

Open eibex opened 2 years ago

eibex commented 2 years ago

⚠️ Before submitting, please verify the following: ⚠️

Bug description

When editing a directory structure you may move files multiple times before they are fully synced, resulting in file lock errors with E2EE (possibly because of how "moving" files works with E2EE - i.e. delete and reupload).

Steps to reproduce

  1. E2EE directory with multiple files
  2. Create a new directory
  3. Move files in the new directory
  4. Create another directory and move some files there again before they are synced

Expected behavior

No leftovers on the servers and continuous sync errors from the desktop client after you remove the apparently locked file/directory.

Which files are affected by this bug

n.a.

Operating system

Windows

Which version of the operating system you are running.

Windows 10

Package

Other

Nextcloud Server version

23.0.4

Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 3.4.2 to 3.4.4)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

Are you using an external user-backend?

Nextcloud Server logs

no server logs errors

Additional info

I am using redis

eibex commented 2 years ago

Also, since the desktop sync remains in error even after the lock expires (meaning that I cannot see the unwated directory on Windows anymore even though it was still on the server), I had to delete the unwanted directory from the iOS app.